Re: [PATCH 1/2] qom: Clean up object_property_get_enum()'s error value

[Daniel P . Berrangé]

On Thu, Sep 17, 2020 at 02:55:39PM +0200, Markus Armbruster wrote:
> object_property_get_enum() is the only object_property_FOO() that is
> documented to return an undefined value on error.  It does no such
> thing, actually: it returns 0 on some errors, and -1 on others.
> 
> Needlessly complicated.  Always return -1 on error, and adjust the
> contract.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  include/qom/object.h       | 6 +++---
>  qom/object.c               | 6 +++---
>  tests/check-qom-proplist.c | 2 ++
>  3 files changed, 8 insertions(+), 6 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|