[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] qom: Correct error values in two contracts
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 2/2] qom: Correct error values in two contracts |
|
Date: |
Thu, 17 Sep 2020 13:59:24 +0100 |
|
User-agent: |
Mutt/1.14.6 (2020-07-11) |
On Thu, Sep 17, 2020 at 02:55:40PM +0200, Markus Armbruster wrote:
> object_property_get_bool()'s contract claims it returns NULL on error.
> Pasto; it returns false.
>
> object_property_get_int()'s contract claims it returns "negative". It
> actually returns -1. All the other object_property_get_FOO()
> contracts specify the exact error value, so do the same here.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> include/qom/object.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH 0/2] qpm: Minor error value corrections, Markus Armbruster, 2020/09/17
- [PATCH 2/2] qom: Correct error values in two contracts, Markus Armbruster, 2020/09/17
- [PATCH 1/2] qom: Clean up object_property_get_enum()'s error value, Markus Armbruster, 2020/09/17
- Re: [PATCH 0/2] qpm: Minor error value corrections, no-reply, 2020/09/17
- Re: [PATCH 0/2] qpm: Minor error value corrections, no-reply, 2020/09/17
- Re: [PATCH 0/2] qpm: Minor error value corrections, Eduardo Habkost, 2020/09/17