[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH] configure: move malloc_trim/tcmalloc/jemalloc to meson |
|
Date: |
Fri, 18 Sep 2020 15:20:57 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 18/09/20 14:55, 罗勇刚(Yonggang Luo) wrote:
>
>> if test "$tcmalloc" = "yes" && test "$jemalloc" = "yes" ; then
>> echo "ERROR: tcmalloc && jemalloc can't be used at the same time"
>> exit 1
>> -fi
> This patch looks good for me, but I still have a small advice than move
> thse judgement from
> configure to meson, because finally they need to be converted.
> and getting tcmalloc / jemalloc to be "enabled" "disabled" for consistence
>
This error cannot apply to meson.build because it uses a single
multi-choice option "-Dmalloc=system|tcmalloc|jemalloc".
Paolo