[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 10/38] qapi/common.py: delint with pylint
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [PATCH v2 10/38] qapi/common.py: delint with pylint |
|
Date: |
Tue, 22 Sep 2020 17:46:51 -0400 |
On Tue, Sep 22, 2020 at 05:00:33PM -0400, John Snow wrote:
> At this point, that just means using a consistent strategy for constant names.
> constants get UPPER_CASE and names not used externally get a leading
> underscore.
>
> As a preference, while renaming constants to be UPPERCASE, move them to
> the head of the file. Generally, it's nice to be able to audit the code
> that runs on import in one central place.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
[PATCH v2 27/38] qapi/gen.py: Remove unused parameter, John Snow, 2020/09/22
[PATCH v2 23/38] qapi/source.py: delint with pylint, John Snow, 2020/09/22
[PATCH v2 11/38] qapi/common.py: Replace one-letter 'c' variable, John Snow, 2020/09/22