[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 29/38] qapi/gen.py: delint with pylint
|
From: |
Cleber Rosa |
|
Subject: |
Re: [PATCH v2 29/38] qapi/gen.py: delint with pylint |
|
Date: |
Thu, 24 Sep 2020 14:44:23 -0400 |
On Tue, Sep 22, 2020 at 05:00:52PM -0400, John Snow wrote:
> 'fp' and 'fd' are self-evident in context, add them to the list of OK
> names.
>
> _top and _bottom also need to stay class methods because some users
> override the method and need to use `self`. Tell pylint to shush.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
With the commit message change caught by Eduardo:
Reviewed-by: Cleber Rosa <crosa@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH v2 25/38] qapi/gen.py: add type hint annotations, (continued)
[PATCH v2 28/38] qapi/gen.py: update write() to be more idiomatic, John Snow, 2020/09/22
Re: [PATCH v2 28/38] qapi/gen.py: update write() to be more idiomatic, Cleber Rosa, 2020/09/24
[PATCH v2 29/38] qapi/gen.py: delint with pylint, John Snow, 2020/09/22
[PATCH v2 10/38] qapi/common.py: delint with pylint, John Snow, 2020/09/22
[PATCH v2 27/38] qapi/gen.py: Remove unused parameter, John Snow, 2020/09/22
[PATCH v2 23/38] qapi/source.py: delint with pylint, John Snow, 2020/09/22