[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 03/38] qapi: move generator entrypoint into module
|
From: |
Cleber Rosa |
|
Subject: |
Re: [PATCH v2 03/38] qapi: move generator entrypoint into module |
|
Date: |
Tue, 22 Sep 2020 20:29:54 -0400 |
On Tue, Sep 22, 2020 at 05:00:26PM -0400, John Snow wrote:
> As part of delinting and adding type hints to the QAPI generator, it's
> helpful for the entrypoint to be part of the package, only leaving a
> very tiny entrypoint shim outside of the module.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> scripts/qapi-gen.py | 90 +++----------------------------------------
> scripts/qapi/main.py | 91 ++++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 97 insertions(+), 84 deletions(-)
> create mode 100644 scripts/qapi/main.py
>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
signature.asc
Description: PGP signature
- Re: [PATCH v2 27/38] qapi/gen.py: Remove unused parameter, (continued)
- [PATCH v2 23/38] qapi/source.py: delint with pylint, John Snow, 2020/09/22
- [PATCH v2 11/38] qapi/common.py: Replace one-letter 'c' variable, John Snow, 2020/09/22
- [PATCH v2 03/38] qapi: move generator entrypoint into module, John Snow, 2020/09/22
- [PATCH v2 20/38] qapi/commands.py: add notational type hints, John Snow, 2020/09/22
- [PATCH v2 24/38] qapi/gen.py: Fix edge-case of _is_user_module, John Snow, 2020/09/22