RE: [PATCH v2 1/3] Optimize seq_sorter function for colo-compare

[Zhang, Chen]

> -----Original Message-----
> From: Rao, Lei <lei.rao@intel.com>
> Sent: Tuesday, September 22, 2020 5:25 PM
> To: Zhang, Chen <chen.zhang@intel.com>; lizhijian@cn.fujitsu.com;
> jasowang@redhat.com; quintela@redhat.com; dgilbert@redhat.com;
> pbonzini@redhat.com
> Cc: qemu-devel@nongnu.org; Rao, Lei <lei.rao@intel.com>
> Subject: [PATCH v2 1/3] Optimize seq_sorter function for colo-compare
> 
> The seq of tcp has been filled in fill_pkt_tcp_info, it can be used directly 
> here.
> 
> Signed-off-by: leirao <lei.rao@intel.com>

Reviewed-by: Zhang Chen <chen.zhang@intel.com>
By the way, please add Zhijian's reviewed-by in new version of patches.

Thanks
Zhang Chen

> ---
>  net/colo-compare.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/net/colo-compare.c b/net/colo-compare.c index
> 3a45d64..86980ce 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -196,11 +196,7 @@ static void
> colo_compare_inconsistency_notify(CompareState *s)
> 
>  static gint seq_sorter(Packet *a, Packet *b, gpointer data)  {
> -    struct tcp_hdr *atcp, *btcp;
> -
> -    atcp = (struct tcp_hdr *)(a->transport_header);
> -    btcp = (struct tcp_hdr *)(b->transport_header);
> -    return ntohl(atcp->th_seq) - ntohl(btcp->th_seq);
> +    return a->tcp_seq - b->tcp_seq;
>  }
> 
>  static void fill_pkt_tcp_info(void *data, uint32_t *max_ack)
> --
> 1.8.3.1