[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 15/38] qapi/common.py: move build_params into gen.py
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [PATCH v2 15/38] qapi/common.py: move build_params into gen.py |
|
Date: |
Wed, 23 Sep 2020 10:26:20 -0400 |
On Tue, Sep 22, 2020 at 05:00:38PM -0400, John Snow wrote:
> Including it in common.py creates a circular import dependency; schema
> relies on common, but common.build_params requires a type annotation
> from schema. To type this properly, it needs to be moved outside the
> cycle.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
--
Eduardo
- [PATCH v2 13/38] qapi/common.py: add type hint annotations, (continued)
- [PATCH v2 14/38] qapi/common.py: Convert comments into docstrings, and elaborate, John Snow, 2020/09/22
- [PATCH v2 15/38] qapi/common.py: move build_params into gen.py, John Snow, 2020/09/22
- [PATCH v2 19/38] qapi/commands.py: Don't re-bind to variable of different type, John Snow, 2020/09/22
- [PATCH v2 16/38] qapi: establish mypy type-checking baseline, John Snow, 2020/09/22
- [PATCH v2 21/38] qapi/commands.py: enable checking with mypy, John Snow, 2020/09/22