Re: [PATCH v2 19/38] qapi/commands.py: Don't re-bind to variable of diff

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 19/38] qapi/commands.py: Don't re-bind to variable of diff

From:	Eduardo Habkost
Subject:	Re: [PATCH v2 19/38] qapi/commands.py: Don't re-bind to variable of different type
Date:	Wed, 23 Sep 2020 10:48:53 -0400

On Tue, Sep 22, 2020 at 05:00:42PM -0400, John Snow wrote:
> Mypy isn't a fan of rebinding a variable with a new data type.
> It's easy enough to avoid.
> 
> Signed-off-by: John Snow <jsnow@redhat.com>

Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>

-- 
Eduardo

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH v2 13/38] qapi/common.py: add type hint annotations, (continued)
- [PATCH v2 14/38] qapi/common.py: Convert comments into docstrings, and elaborate, John Snow, 2020/09/22
  - Re: [PATCH v2 14/38] qapi/common.py: Convert comments into docstrings, and elaborate, Eduardo Habkost, 2020/09/23
  - Re: [PATCH v2 14/38] qapi/common.py: Convert comments into docstrings, and elaborate, Cleber Rosa, 2020/09/23
    - Re: [PATCH v2 14/38] qapi/common.py: Convert comments into docstrings, and elaborate, John Snow, 2020/09/23
- [PATCH v2 15/38] qapi/common.py: move build_params into gen.py, John Snow, 2020/09/22
  - Re: [PATCH v2 15/38] qapi/common.py: move build_params into gen.py, Eduardo Habkost, 2020/09/23
  - Re: [PATCH v2 15/38] qapi/common.py: move build_params into gen.py, Cleber Rosa, 2020/09/23
- [PATCH v2 19/38] qapi/commands.py: Don't re-bind to variable of different type, John Snow, 2020/09/22
  - Re: [PATCH v2 19/38] qapi/commands.py: Don't re-bind to variable of different type, Eduardo Habkost <=
  - Re: [PATCH v2 19/38] qapi/commands.py: Don't re-bind to variable of different type, Cleber Rosa, 2020/09/23
- [PATCH v2 16/38] qapi: establish mypy type-checking baseline, John Snow, 2020/09/22
  - Re: [PATCH v2 16/38] qapi: establish mypy type-checking baseline, Eduardo Habkost, 2020/09/23
  - Re: [PATCH v2 16/38] qapi: establish mypy type-checking baseline, Cleber Rosa, 2020/09/23
- [PATCH v2 21/38] qapi/commands.py: enable checking with mypy, John Snow, 2020/09/22
  - Re: [PATCH v2 21/38] qapi/commands.py: enable checking with mypy, Eduardo Habkost, 2020/09/23
  - Re: [PATCH v2 21/38] qapi/commands.py: enable checking with mypy, Cleber Rosa, 2020/09/23
    - Re: [PATCH v2 21/38] qapi/commands.py: enable checking with mypy, John Snow, 2020/09/23
- [PATCH v2 22/38] qapi/source.py: add type hint annotations, John Snow, 2020/09/22
  - Re: [PATCH v2 22/38] qapi/source.py: add type hint annotations, Eduardo Habkost, 2020/09/23

Prev by Date: Re: [PATCH v2 18/38] qapi/events.py: Move comments into docstrings
Next by Date: Re: [PATCH v2 20/38] qapi/commands.py: add notational type hints
Previous by thread: [PATCH v2 19/38] qapi/commands.py: Don't re-bind to variable of different type
Next by thread: Re: [PATCH v2 19/38] qapi/commands.py: Don't re-bind to variable of different type
Index(es):
- Date
- Thread