Re: [PATCH v2 21/38] qapi/commands.py: enable checking with mypy

[John Snow]

On 9/23/20 6:21 PM, Cleber Rosa wrote:
> On Tue, Sep 22, 2020 at 05:00:44PM -0400, John Snow wrote:
> > Signed-off-by: John Snow <jsnow@redhat.com>
> > ---
> >   scripts/qapi/mypy.ini | 5 -----
> >   1 file changed, 5 deletions(-)
> >
> > diff --git a/scripts/qapi/mypy.ini b/scripts/qapi/mypy.ini
> > index b668776d94..9da1dccef4 100644
> > --- a/scripts/qapi/mypy.ini
> > +++ b/scripts/qapi/mypy.ini
> > @@ -4,11 +4,6 @@ strict_optional = False
> >   disallow_untyped_calls = False
> >   python_version = 3.6
> >   
> > -[mypy-qapi.commands]
> > -disallow_untyped_defs = False
> > -disallow_incomplete_defs = False
> > -check_untyped_defs = False
> > -
> >   [mypy-qapi.doc]
> >   disallow_subclassing_any = False
> >   disallow_untyped_defs = False
> > --
> > 2.26.2
>
> IMO, this increase of strictness for "commands" would make more sense
> to be squashed together with the previous changes on "commands.py".
> Not only here, but for the other patches for the other modules too.
>
> Anyway,
>
> Reviewed-by: Cleber Rosa <crosa@redhat.com>

Admittedly, the only reason I *didn't* is because these patches have 
been reordered a *lot* and in some cases, it helped me to have distinct 
"This patch is last and enables the checks!" commits.

(I am hedging my bets that more re-ordering is in my future.)

I will squash the "Enable such-and-such" commits with whatever fixed the 
last error for final inclusion, but I might keep them separate for now 
just for my own convenience.

Sorry for the volume.

--js