[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 16/37] qapi: establish mypy type-checking baseline
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [PATCH 16/37] qapi: establish mypy type-checking baseline |
|
Date: |
Thu, 24 Sep 2020 21:18:21 -0400 |
On Mon, Sep 21, 2020 at 10:05:24AM +0200, Markus Armbruster wrote:
[...]
> I sense a certain wobbliness in mypy. Perhaps to be expected from a
> tool with major version zero. There's a risk that developers' local
> "make check" and our gating CI differ too much. We'll see.
This possibility shouldn't exist. If you don't have the required
version in your system, the validation script must know how to
create a virtualenv and install the right version inside it.
--
Eduardo
- Re: [PATCH 15/37] qapi/common.py: split build_params into new file, (continued)
- [PATCH 24/37] qapi/gen.py: Fix edge-case of _is_user_module, John Snow, 2020/09/15
- [PATCH 21/37] qapi/commands.py: enable checking with mypy, John Snow, 2020/09/15
- [PATCH 16/37] qapi: establish mypy type-checking baseline, John Snow, 2020/09/15
- Re: [PATCH 16/37] qapi: establish mypy type-checking baseline, John Snow, 2020/09/18
- Re: [PATCH 16/37] qapi: establish mypy type-checking baseline, Markus Armbruster, 2020/09/21
- Re: [PATCH 16/37] qapi: establish mypy type-checking baseline, John Snow, 2020/09/21
[PATCH 18/37] qapi/events.py: Move comments into docstrings, John Snow, 2020/09/15
[PATCH 22/37] qapi/source.py: add notational type hints, John Snow, 2020/09/15
[PATCH 19/37] qapi/commands.py: Don't re-bind to variable of different type, John Snow, 2020/09/15
[PATCH 17/37] qapi/events.py: add notational type hints, John Snow, 2020/09/15
[PATCH 20/37] qapi/commands.py: add notational type hints, John Snow, 2020/09/15
[PATCH 23/37] qapi/source.py: delint with pylint, John Snow, 2020/09/15
[PATCH 28/37] qapi/gen.py: update write() to be more idiomatic, John Snow, 2020/09/15