Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static d

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static d

From:	John Snow
Subject:	Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data
Date:	Thu, 24 Sep 2020 21:12:06 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/24/20 9:03 PM, Cleber Rosa wrote:

On Tue, Sep 22, 2020 at 05:13:11PM -0400, John Snow wrote:

It is -- maybe -- possibly -- three nanoseconds faster.


Kevin O'Leary would clearly say here: "stop the madness!" :)

Signed-off-by: John Snow <jsnow@redhat.com>


Reviewed-by: Cleber Rosa <crosa@redhat.com>


I can explain!

When I sat down to write this series, I just "cleaned" in generalwithout regard to what was strictly necessary and what wasn't.

Once I had to split them out, brick-by-brick, some things looked muchmore frivolous than others, but I had already written and tested them, so...


Well. There are definitely a few unimportant patches here.

--js

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 13/16] qapi/expr.py: Modify check_keys to accept any Iterable, (continued)
- [PATCH 13/16] qapi/expr.py: Modify check_keys to accept any Iterable, John Snow, 2020/09/22
  - Re: [PATCH 13/16] qapi/expr.py: Modify check_keys to accept any Iterable, Eduardo Habkost, 2020/09/23
  - Re: [PATCH 13/16] qapi/expr.py: Modify check_keys to accept any Iterable, Cleber Rosa, 2020/09/24
- [PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions, John Snow, 2020/09/22
  - Re: [PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions, Eduardo Habkost, 2020/09/23
    - Re: [PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions, John Snow, 2020/09/24
  - Re: [PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions, Cleber Rosa, 2020/09/24
- [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, John Snow, 2020/09/22
  - Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, Eduardo Habkost, 2020/09/23
  - Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, Cleber Rosa, 2020/09/24
    - Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, John Snow <=
- [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/22
  - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Eduardo Habkost, 2020/09/23
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/24
  - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Cleber Rosa, 2020/09/24
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/24
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Helio Loureiro, 2020/09/25
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/25
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Helio Loureiro, 2020/09/26
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/30
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Cleber Rosa, 2020/09/25

Prev by Date: Re: [PATCH 12/16] qapi/expr.py: Add docstrings
Next by Date: Re: [PATCH 16/37] qapi: establish mypy type-checking baseline
Previous by thread: Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data
Next by thread: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table
Index(es):
- Date
- Thread