Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

From:	John Snow
Subject:	Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table
Date:	Thu, 24 Sep 2020 21:32:05 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/24/20 9:18 PM, Cleber Rosa wrote:

I have to say the style of this line bothers me, but it's just that,
style. So,


What don't you like?

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions, (continued)
- [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, John Snow, 2020/09/22
  - Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, Eduardo Habkost, 2020/09/23
  - Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, Cleber Rosa, 2020/09/24
    - Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, John Snow, 2020/09/24
- [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/22
  - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Eduardo Habkost, 2020/09/23
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/24
  - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Cleber Rosa, 2020/09/24
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow <=
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Helio Loureiro, 2020/09/25
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/25
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Helio Loureiro, 2020/09/26
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/30
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Cleber Rosa, 2020/09/25
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/25
- Re: [PATCH 00/16] qapi: static typing conversion, pt2, John Snow, 2020/09/25

Prev by Date: Re: [PATCH 04/16] qapi/expr.py: Add assertion for union type 'check_dict'
Next by Date: [Bug 1897194] [NEW] Test failure in test-crypto-secret.c
Previous by thread: Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table
Next by thread: Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table
Index(es):
- Date
- Thread