[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table
|
From: |
Cleber Rosa |
|
Subject: |
Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table |
|
Date: |
Fri, 25 Sep 2020 12:38:22 -0400 |
On Thu, Sep 24, 2020 at 09:32:05PM -0400, John Snow wrote:
> On 9/24/20 9:18 PM, Cleber Rosa wrote:
> > I have to say the style of this line bothers me, but it's just that,
> > style. So,
>
> What don't you like?
It's the sum of the "private" + "global dictionary" + "its item being
called directly".
But don't bother, this is probably the kind of comment that I should
omit, as I don't want you to, say, create a wrapper function around
the dict, partially defeating the purpose of this patch.
- Cleber.
signature.asc
Description: PGP signature
- Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, (continued)
- [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/22
- Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Eduardo Habkost, 2020/09/23
- Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Cleber Rosa, 2020/09/24
- Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/24
- Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Helio Loureiro, 2020/09/25
- Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/25
- Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Helio Loureiro, 2020/09/26
- Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/30
- Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table,
Cleber Rosa <=
- Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/25
Re: [PATCH 00/16] qapi: static typing conversion, pt2, John Snow, 2020/09/25