Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table

From:	John Snow
Subject:	Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table
Date:	Thu, 24 Sep 2020 20:59:20 -0400
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

On 9/23/20 4:36 PM, Eduardo Habkost wrote:

I see lots of meta.value expressions below.  Maybe setting
   meta = kind.value
will make the code more readable?


I can do that.

I don't think this should block an obvious improvement to the
code, so:

Reviewed-by: Eduardo Habkost<ehabkost@redhat.com>


Thanks!

--js

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions, (continued)
- [PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions, John Snow, 2020/09/22
  - Re: [PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions, Eduardo Habkost, 2020/09/23
    - Re: [PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions, John Snow, 2020/09/24
  - Re: [PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions, Cleber Rosa, 2020/09/24
- [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, John Snow, 2020/09/22
  - Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, Eduardo Habkost, 2020/09/23
  - Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, Cleber Rosa, 2020/09/24
    - Re: [PATCH 14/16] qapi/expr.py: Use tuples instead of lists for static data, John Snow, 2020/09/24
- [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/22
  - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Eduardo Habkost, 2020/09/23
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow <=
  - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Cleber Rosa, 2020/09/24
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/24
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Helio Loureiro, 2020/09/25
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/25
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Helio Loureiro, 2020/09/26
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/30
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, Cleber Rosa, 2020/09/25
    - Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table, John Snow, 2020/09/25
- Re: [PATCH 00/16] qapi: static typing conversion, pt2, John Snow, 2020/09/25

Prev by Date: Re: [PATCH 15/16] qapi/expr.py: move related checks inside check_xxx functions
Next by Date: Re: [PATCH 12/16] qapi/expr.py: Add docstrings
Previous by thread: Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table
Next by thread: Re: [PATCH 16/16] qapi/expr.py: Use an expression checker dispatch table
Index(es):
- Date
- Thread