[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/12] tests/9pfs: refactor test names and test devices
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 08/12] tests/9pfs: refactor test names and test devices |
|
Date: |
Mon, 28 Sep 2020 10:37:52 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 27/09/20 12:40, Christian Schoenebeck wrote:
> + qos_node_consumes("virtio-9p-device-local", "virtio-bus", &opts);
> + qos_node_produces("virtio-9p-device-local", "virtio-local");
This should produce "virtio", similar to what I remarked in the previous
patch.
> + qos_node_produces("virtio-9p-device-local", "virtio-9p-local");
> +
> + /* virtio-9p-pci-local */
> + opts.extra_device_opts = local_str_addr;
> + add_qpci_address(&opts, &addr);
> + qos_node_create_driver_named("virtio-9p-pci-local", "virtio-9p-pci",
> + virtio_9p_pci_create);
> + qos_node_consumes("virtio-9p-pci-local", "pci-bus", &opts);
> + qos_node_produces("virtio-9p-pci-local", "pci-device");
> + qos_node_produces("virtio-9p-pci-local", "virtio-local");
> + qos_node_produces("virtio-9p-pci-local", "virtio-9p-local");
> }
The implementation in patches 1 and 2 is reasonable, but what is the
advantage of this as opposed to specifying the fsdev in the edge options
for the test (similar to virtio-net)? I was expecting both
virtio-9p-device-synth and virtio-9p-device-local to produce virtio-9p,
so that the existing tests would be reused automatically by the qos
graph walk.
As things stand, I don't see any reason to have separate devices for
different backends.
Paolo
- Re: [PATCH 06/12] tests/qtest/qos-test: add environment variable QTEST_DEBUG, (continued)
- [PATCH 07/12] test/9pfs: change export tag name to qtest-synth, Christian Schoenebeck, 2020/09/27
- [PATCH 04/12] tests/qtest/qos-test: new QTEST_DUMP_GRAPH environment variable, Christian Schoenebeck, 2020/09/27
- [PATCH 02/12] tests/qtest/qgraph: add qos_node_create_driver_named(), Christian Schoenebeck, 2020/09/27
- [PATCH 01/12] tests/qtest/qgraph: add qemu_name to QOSGraphNode, Christian Schoenebeck, 2020/09/27
- [PATCH 09/12] tests/9pfs: introduce local tests, Christian Schoenebeck, 2020/09/27
- [PATCH 03/12] tests/qtest/qos: add qos_dump_graph(), Christian Schoenebeck, 2020/09/27
- [PATCH 08/12] tests/9pfs: refactor test names and test devices, Christian Schoenebeck, 2020/09/27
[PATCH 10/12] tests/9pfs: wipe local 9pfs test directory, Christian Schoenebeck, 2020/09/27
[PATCH 11/12] tests/9pfs: add virtio_9p_test_path(), Christian Schoenebeck, 2020/09/27