[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 08/12] tests/9pfs: refactor test names and test devices
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH 08/12] tests/9pfs: refactor test names and test devices |
|
Date: |
Mon, 28 Sep 2020 18:38:00 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
On 28/09/20 15:35, Christian Schoenebeck wrote:
>> As I said, the first two patches make total sense. They would be useful
>> for testing both packed and split virtqueues, for example. However, I
>> think the (useful) feature is being misused here.
>
> I haven't understood why my suggested mult-device use case imposes a
> misusage,
> but okay, unless I hear different opinions, I'll prepare a v2 with that (IMO
> hackish) CL fiddling instead in couple days or so.
Because in my opinion the backend in use is a property of the test
rather than a property of the device.
> @Greg: If that's the way to go, then I probably change the test names, e.g.
>
> "fs/version/basic" -> "synth/version/basic"
> ...
> "fs/create_dir" -> "local/create_dir"
>
> to be able to easily distinguish 'synth' driver tests from 'local' driver
> tests, as they would then popup with the same device name in v2, unlike in
> this v1 where they have separate device names.
Right.
>> Also, looking at future plans for qgraph, adding a generic "plug/socket"
>> mechanism to QOSGraph was an idea that we couldn't do in time for GSoC.
>> With that model, virtio-9p would provide a "socket" of type fsdev and
>> the tests would have to provide a "plug" of the same type. Likewise
>> there would be sockets of type disk or network. QOSGraphEdgeOpts fits
>> better with that plan, compared to duplicating the devices.
>
> Sounds like that would require huge changes for all existing qtests on
> initial
> thought at least.
Not huge, but yeah many tests would require changes.
Paolo
- [PATCH 02/12] tests/qtest/qgraph: add qos_node_create_driver_named(), (continued)
- [PATCH 02/12] tests/qtest/qgraph: add qos_node_create_driver_named(), Christian Schoenebeck, 2020/09/27
- [PATCH 01/12] tests/qtest/qgraph: add qemu_name to QOSGraphNode, Christian Schoenebeck, 2020/09/27
- [PATCH 09/12] tests/9pfs: introduce local tests, Christian Schoenebeck, 2020/09/27
- [PATCH 03/12] tests/qtest/qos: add qos_dump_graph(), Christian Schoenebeck, 2020/09/27
- [PATCH 08/12] tests/9pfs: refactor test names and test devices, Christian Schoenebeck, 2020/09/27
[PATCH 10/12] tests/9pfs: wipe local 9pfs test directory, Christian Schoenebeck, 2020/09/27
[PATCH 11/12] tests/9pfs: add virtio_9p_test_path(), Christian Schoenebeck, 2020/09/27