[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute '
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf' |
Date: |
Mon, 28 Sep 2020 14:58:57 +0200 |
Since commit efc6c070aca ("configure: Add a test for the minimum
compiler version") the minimum compiler version required for GCC
is 4.8, which supports the gnu_printf attribute.
We can safely remove the code introduced in commit 9c9e7d51bf0
("Move macros GCC_ATTR and GCC_FMT_ATTR to common header file").
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
include/qemu/compiler.h | 19 ++++++++-----------
1 file changed, 8 insertions(+), 11 deletions(-)
diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h
index c76281f3540..207e3bd4feb 100644
--- a/include/qemu/compiler.h
+++ b/include/qemu/compiler.h
@@ -104,17 +104,14 @@
sizeof(QEMU_BUILD_BUG_ON_STRUCT(x)))
#if defined __GNUC__
-# if !QEMU_GNUC_PREREQ(4, 4)
- /* gcc versions before 4.4.x don't support gnu_printf, so use printf. */
-# define GCC_FMT_ATTR(n, m) __attribute__((format(printf, n, m)))
-# else
- /* Use gnu_printf when supported (qemu uses standard format strings). */
-# define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m)))
-# if defined(_WIN32)
- /* Map __printf__ to __gnu_printf__ because we want standard format strings
- * even when MinGW or GLib include files use __printf__. */
-# define __printf__ __gnu_printf__
-# endif
+ /* Use gnu_printf when supported (qemu uses standard format strings). */
+# define GCC_FMT_ATTR(n, m) __attribute__((format(gnu_printf, n, m)))
+# if defined(_WIN32)
+ /*
+ * Map __printf__ to __gnu_printf__ because we want standard format strings
+ * even when MinGW or GLib include files use __printf__.
+ */
+# define __printf__ __gnu_printf__
# endif
#else
#define GCC_FMT_ATTR(n, m)
--
2.26.2
- [PATCH 0/3] qemu/compiler: Remove unused special case code for GCC < 4.8, Philippe Mathieu-Daudé, 2020/09/28
- [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf',
Philippe Mathieu-Daudé <=
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Peter Maydell, 2020/09/28
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Daniel P . Berrangé, 2020/09/28
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Peter Maydell, 2020/09/28
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Daniel P . Berrangé, 2020/09/28
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Peter Maydell, 2020/09/28
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Daniel P . Berrangé, 2020/09/28
- Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf', Paolo Bonzini, 2020/09/28
[PATCH 2/3] qemu/atomic: Drop special case for unsupported compiler, Philippe Mathieu-Daudé, 2020/09/28
[PATCH 3/3] accel/tcg: Remove special case for GCC < 4.6, Philippe Mathieu-Daudé, 2020/09/28