Re: [PATCH 1/3] qemu/compiler: Simplify as all compilers support attribute 'gnu_printf'

[Peter Maydell]

On Mon, 28 Sep 2020 at 15:06, Daniel P. Berrangé <berrange@redhat.com> wrote:
> I think this can be simplified even more by using GLib's macros
>
>   #define GCC_FMT_ATTR(n, m)  G_GNUC_PRINTF(n, m)

At least on my system G_GNUC_PRINTF() expands to
__format__(__printf__,...), not gnu_printf, so it is
not quite what we want. (The difference is that on Windows
hosts we still want to mark up our our logging functions as
taking the glibc style format handling, not whatever the
MS C library format escapes happen to be.)
At a minimum you'd need to keep in the "on Windows,
redefine __printf__ to __gnu_printf__" logic.

See also commit 95df51a4a02a853.

thanks
-- PMM