Re: [PATCH 3/3] accel/tcg: Remove special case for GCC < 4.6

[Peter Maydell]

On Mon, 28 Sep 2020 at 14:40, Philippe Mathieu-Daudé <philmd@redhat.com> wrote:
>
> Since commit efc6c070aca ("configure: Add a test for the
> minimum compiler version") the minimum compiler version
> required for GCC is 4.8.
>
> We can safely remove the special case for GCC 4.6 introduced
> in commit 0448f5f8b81 ("cpu-exec: Fix compiler warning
> (-Werror=clobbered)").
> No change for Clang as we don't know.

Looking through the git history the inclusion of "clang" in
this workaround is because a bug was noticed with the FreeBSD
clang which prompted commit 6c78f29a2424622bfc9c3 in 2013.
It's quite tempting to assume newer clangs have fixed this,
but still I guess it's safest to leave the workaround in place...

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM