qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v4 00/29] Hexagon patch series

From: no-reply
Subject: Re: [RFC PATCH v4 00/29] Hexagon patch series
Date: Mon, 28 Sep 2020 18:12:36 -0700 (PDT) 
Patchew URL: 
1601314138-9930-1-git-send-email-tsimpson@quicinc.com/">https://patchew.org/QEMU/1601314138-9930-1-git-send-email-tsimpson@quicinc.com/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 1601314138-9930-1-git-send-email-tsimpson@quicinc.com
Subject: [RFC PATCH v4 00/29] Hexagon patch series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
07b7654 Hexagon build infrastructure
010f970 Hexagon (tests/tcg/hexagon) TCG tests
6d5cc34 Hexagon (linux-user/hexagon) Linux user emulation
2cc6884 Hexagon (target/hexagon) translation
78dc364 Hexagon (target/hexagon) TCG for instructions with multiple definitions
7da73c1 Hexagon (target/hexagon) TCG generation
2667588 Hexagon (target/hexagon) instruction classes
6447bfd Hexagon (target/hexagon) macros
09a6ee0 Hexagon (target/hexagon) opcode data structures
0a72ce4 Hexagon (target/hexagon) generater phase 4 - decode tree
e10510a Hexagon (target/hexagon) generator phase 3 - C preprocessor for decode 
tree
e13fc67 Hexagon (target/hexagon) generator phase 2 - generate header files
c51b8ef Hexagon (target/hexagon) generator phase 1 - C preprocessor for 
semantics
8e3991c Hexagon (target/hexagon/imported) arch import
aaa7fdf Hexagon (target/hexagon) utility functions
e10964e Hexagon (target/hexagon) instruction printing
78eb919 Hexagon (target/hexagon) instruction/packet decode
71da9a7 Hexagon (target/hexagon) instruction attributes
14de848 Hexagon (target/hexagon) register fields
e51e071 Hexagon (target/hexagon) instruction and packet types
7aa4ff5 Hexagon (target/hexagon) architecture types
cd303dc Hexagon (target/hexagon) GDB Stub
acb70e2 Hexagon (target/hexagon) scalar core helpers
c5c476c Hexagon (target/hexagon) register names
dcf7c0c Hexagon (disas) disassembler
6564db7 Hexagon (target/hexagon) scalar core definition
a5ea831 Hexagon (include/elf.h) ELF machine definition
73fa471 Hexagon (target/hexagon) README
83d6242 Hexagon Update MAINTAINERS file

=== OUTPUT BEGIN ===
1/29 Checking commit 83d6242ea963 (Hexagon Update MAINTAINERS file)
2/29 Checking commit 73fa4715a018 (Hexagon (target/hexagon) README)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 236 lines checked

Patch 2/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/29 Checking commit a5ea8316fe44 (Hexagon (include/elf.h) ELF machine 
definition)
4/29 Checking commit 6564db7eff40 (Hexagon (target/hexagon) scalar core 
definition)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 570 lines checked

Patch 4/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
5/29 Checking commit dcf7c0cbc41a (Hexagon (disas) disassembler)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 76 lines checked

Patch 5/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/29 Checking commit c5c476c4cb67 (Hexagon (target/hexagon) register names)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#12: 
new file mode 100644

total: 0 errors, 1 warnings, 83 lines checked

Patch 6/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
7/29 Checking commit acb70e2f6042 (Hexagon (target/hexagon) scalar core helpers)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 412 lines checked

Patch 7/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
8/29 Checking commit cd303dc889e2 (Hexagon (target/hexagon) GDB Stub)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#27: 
new file mode 100644

total: 0 errors, 1 warnings, 64 lines checked

Patch 8/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
9/29 Checking commit 7aa4ff557b75 (Hexagon (target/hexagon) architecture types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 43 lines checked

Patch 9/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/29 Checking commit e51e0716fa19 (Hexagon (target/hexagon) instruction and 
packet types)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 74 lines checked

Patch 10/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/29 Checking commit 14de84860eaa (Hexagon (target/hexagon) register fields)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#80: FILE: target/hexagon/reg_fields.h:29:
+#define DEF_REG_FIELD(TAG, START, WIDTH) \
+    TAG,

total: 1 errors, 1 warnings, 105 lines checked

Patch 11/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

12/29 Checking commit 71da9a7c0527 (Hexagon (target/hexagon) instruction 
attributes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#37: FILE: target/hexagon/attribs.h:22:
+#define DEF_ATTRIB(NAME, ...) A_##NAME,

total: 1 errors, 1 warnings, 130 lines checked

Patch 12/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

13/29 Checking commit 78eb9192e26e (Hexagon (target/hexagon) instruction/packet 
decode)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#22: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#133: FILE: target/hexagon/decode.c:107:
+#define DECODE_SEPARATOR_BITS(START, WIDTH) NULL, START, WIDTH

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#734: FILE: target/hexagon/q6v_decode.c:51:
+#define DECODE_OPINFO(TAG, BEH) \
+    case TAG: \
+        { BEH  } \
+        break; \
+

total: 2 errors, 1 warnings, 1018 lines checked

Patch 13/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

14/29 Checking commit e10964e7afdd (Hexagon (target/hexagon) instruction 
printing)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

ERROR: Macros with multiple statements should be enclosed in a do - while loop
#58: FILE: target/hexagon/printinsn.c:43:
+#define DEF_PRINTINFO(TAG, FMT, ...) \
+    case TAG: \
+        snprintf(buf, n, FMT, __VA_ARGS__);\
+        break;

total: 1 errors, 1 warnings, 117 lines checked

Patch 14/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

15/29 Checking commit aaa7fdf81e1f (Hexagon (target/hexagon) utility functions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

WARNING: Block comments use a leading /* on a separate line
#1325: FILE: target/hexagon/fma_emu.c:469:
+        /* result zero */ \

WARNING: Block comments use a leading /* on a separate line
#1333: FILE: target/hexagon/fma_emu.c:477:
+    /* Normalize right */ \

WARNING: Block comments use a leading /* on a separate line
#1334: FILE: target/hexagon/fma_emu.c:478:
+    /* We want MANTBITS bits of mantissa plus the leading one. */ \

WARNING: Block comments use a leading /* on a separate line
#1335: FILE: target/hexagon/fma_emu.c:479:
+    /* That means that we want MANTBITS+1 bits, or 0x000000000000FF_FFFF */ \

WARNING: Block comments use a leading /* on a separate line
#1336: FILE: target/hexagon/fma_emu.c:480:
+    /* So we need to normalize right while the high word is non-zero and \

WARNING: Block comments should align the * on each line
#1337: FILE: target/hexagon/fma_emu.c:481:
+    /* So we need to normalize right while the high word is non-zero and \
+    * while the low word is nonzero when masked with 0xffe0_0000_0000_0000 */ \

WARNING: Block comments use a leading /* on a separate line
#1341: FILE: target/hexagon/fma_emu.c:485:
+    /* \

WARNING: Block comments use a leading /* on a separate line
#1351: FILE: target/hexagon/fma_emu.c:495:
+    /* \

WARNING: Block comments use a leading /* on a separate line
#1358: FILE: target/hexagon/fma_emu.c:502:
+        /* \

WARNING: Block comments use a leading /* on a separate line
#1367: FILE: target/hexagon/fma_emu.c:511:
+    /* OK, we're relatively canonical... now we need to round */ \

WARNING: Block comments use a leading /* on a separate line
#1372: FILE: target/hexagon/fma_emu.c:516:
+            /* Chop and we're done */ \

WARNING: Block comments use a leading /* on a separate line
#1386: FILE: target/hexagon/fma_emu.c:530:
+                /* round up if guard is 1, down if guard is zero */ \

WARNING: Block comments use a leading /* on a separate line
#1389: FILE: target/hexagon/fma_emu.c:533:
+                /* exactly .5, round up if odd */ \

WARNING: Block comments use a leading /* on a separate line
#1395: FILE: target/hexagon/fma_emu.c:539:
+    /* \

WARNING: Block comments use a leading /* on a separate line
#1404: FILE: target/hexagon/fma_emu.c:548:
+    /* Overflow? */ \

WARNING: Block comments use a leading /* on a separate line
#1406: FILE: target/hexagon/fma_emu.c:550:
+        /* Yep, inf result */ \

WARNING: Block comments use a leading /* on a separate line
#1428: FILE: target/hexagon/fma_emu.c:572:
+    /* Underflow? */ \

WARNING: Block comments use a leading /* on a separate line
#1430: FILE: target/hexagon/fma_emu.c:574:
+        /* Leading one means: No, we're normal. So, we should be done... */ \

total: 0 errors, 19 warnings, 1619 lines checked

Patch 15/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
16/29 Checking commit 8e3991cea132 (Hexagon (target/hexagon/imported) arch 
import)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#28: 
new file mode 100644

total: 0 errors, 1 warnings, 9251 lines checked

Patch 16/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
17/29 Checking commit c51b8efd689a (Hexagon (target/hexagon) generator phase 1 
- C preprocessor for semantics)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

ERROR: suspicious ; after while (0)
#82: FILE: target/hexagon/gen_semantics.c:61:
+    } while (0);

total: 1 errors, 1 warnings, 88 lines checked

Patch 17/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

18/29 Checking commit e13fc6785aa7 (Hexagon (target/hexagon) generator phase 2 
- generate header files)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
new file mode 100755

WARNING: line over 80 characters
#1051: FILE: target/hexagon/gen_tcg_funcs.py:50:
+        f.write("        tcg_gen_mov_tl(hex_new_value[%s + 1], hex_gpr[%s + 
1]);\n" % \

WARNING: line over 80 characters
#1130: FILE: target/hexagon/gen_tcg_funcs.py:129:
+            f.write("    TCGv %s%sN = hex_new_pred_value[insn->regno[%d]];\n" 
% \

WARNING: line over 80 characters
#1215: FILE: target/hexagon/gen_tcg_funcs.py:214:
+            f.write("                                 hex_gpr[%s%sN + 1]);\n" 
% \

WARNING: line over 80 characters
#1236: FILE: target/hexagon/gen_tcg_funcs.py:235:
+            f.write("                                     hex_gpr[%s%sN + 
1]);\n" % \

WARNING: line over 80 characters
#1240: FILE: target/hexagon/gen_tcg_funcs.py:239:
+            f.write("        tcg_gen_concat_i32_i64(%s%sV, hex_gpr[%s%sN],\n" 
% \

WARNING: line over 80 characters
#1242: FILE: target/hexagon/gen_tcg_funcs.py:241:
+            f.write("                                     hex_gpr[%s%sN + 
1]);\n" % \

WARNING: line over 80 characters
#1251: FILE: target/hexagon/gen_tcg_funcs.py:250:
+            f.write("        tcg_gen_mov_tl(%s%sV, hex_gpr[%s%sN + 
HEX_REG_SA0]);\n" % \

WARNING: line over 80 characters
#1311: FILE: target/hexagon/gen_tcg_funcs.py:310:
+        f.write("    gen_log_predicated_reg_write_pair(%s%sN, %s%sV, 
insn->slot);\n" % \

WARNING: line over 80 characters
#1355: FILE: target/hexagon/gen_tcg_funcs.py:354:
+            f.write("        gen_log_reg_write(%s%sN + HEX_REG_SA0 + 1, 
val32);\n" % \

WARNING: line over 80 characters
#1358: FILE: target/hexagon/gen_tcg_funcs.py:357:
+            f.write("        ctx_log_reg_write(ctx, %s%sN + HEX_REG_SA0 + 
1);\n" % \

WARNING: line over 80 characters
#1361: FILE: target/hexagon/gen_tcg_funcs.py:360:
+            f.write("        gen_log_reg_write_pair(%s%sN + HEX_REG_SA0, 
%s%sV);\n" % \

WARNING: line over 80 characters
#1365: FILE: target/hexagon/gen_tcg_funcs.py:364:
+            f.write("        ctx_log_reg_write(ctx, %s%sN + HEX_REG_SA0 + 
1);\n" % \

WARNING: line over 80 characters
#1374: FILE: target/hexagon/gen_tcg_funcs.py:373:
+            f.write("        gen_log_reg_write(%s%sN + HEX_REG_SA0, %s%sV);\n" 
% \

total: 0 errors, 14 warnings, 1676 lines checked

Patch 18/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
19/29 Checking commit e10510a91bcd (Hexagon (target/hexagon) generator phase 3 
- C preprocessor for decode tree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#76: FILE: target/hexagon/gen_dectree_import.c:57:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS,

ERROR: Macros with complex values should be enclosed in parenthesis
#85: FILE: target/hexagon/gen_dectree_import.c:66:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS,

ERROR: suspicious ; after while (0)
#182: FILE: target/hexagon/gen_dectree_import.c:163:
+    } while (0);

total: 3 errors, 1 warnings, 191 lines checked

Patch 19/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

20/29 Checking commit 0a72ce4c7218 (Hexagon (target/hexagon) generater phase 4 
- decode tree)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100755

total: 0 errors, 1 warnings, 352 lines checked

Patch 20/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
21/29 Checking commit 09a6ee0edd8d (Hexagon (target/hexagon) opcode data 
structures)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#11: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#56: FILE: target/hexagon/opcodes.c:41:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) REGINFO,

ERROR: Macros with complex values should be enclosed in parenthesis
#66: FILE: target/hexagon/opcodes.c:51:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) RREGS,

ERROR: Macros with complex values should be enclosed in parenthesis
#76: FILE: target/hexagon/opcodes.c:61:
+#define REGINFO(TAG, REGINFO, RREGS, WREGS) WREGS,

ERROR: Macros with complex values should be enclosed in parenthesis
#84: FILE: target/hexagon/opcodes.c:69:
+#define DEF_SHORTCODE(TAG, SHORTCODE)              [TAG] = #SHORTCODE,

ERROR: Macros with complex values should be enclosed in parenthesis
#180: FILE: target/hexagon/opcodes.c:165:
+#define ATTRIBS(...) , ## __VA_ARGS__, 0

total: 5 errors, 1 warnings, 265 lines checked

Patch 21/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

22/29 Checking commit 6447bfd79ac7 (Hexagon (target/hexagon) macros)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 654 lines checked

Patch 22/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
23/29 Checking commit 2667588652d9 (Hexagon (target/hexagon) instruction 
classes)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

ERROR: Macros with complex values should be enclosed in parenthesis
#130: FILE: target/hexagon/iclass.h:27:
+#define DEF_PP_ICLASS32(TYPE, SLOTS, UNITS)    ICLASS_FROM_TYPE(TYPE),

ERROR: Macros with complex values should be enclosed in parenthesis
#131: FILE: target/hexagon/iclass.h:28:
+#define DEF_EE_ICLASS32(TYPE, SLOTS, UNITS)    ICLASS_FROM_TYPE(TYPE),

total: 2 errors, 1 warnings, 172 lines checked

Patch 23/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

24/29 Checking commit 7da73c149bf2 (Hexagon (target/hexagon) TCG generation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#13: 
new file mode 100644

total: 0 errors, 1 warnings, 259 lines checked

Patch 24/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
25/29 Checking commit 78dc36465e5d (Hexagon (target/hexagon) TCG for 
instructions with multiple definitions)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#14: 
new file mode 100644

total: 0 errors, 1 warnings, 198 lines checked

Patch 25/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
26/29 Checking commit 2cc688488079 (Hexagon (target/hexagon) translation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#17: 
new file mode 100644

total: 0 errors, 1 warnings, 767 lines checked

Patch 26/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
27/29 Checking commit 6d5cc34654af (Hexagon (linux-user/hexagon) Linux user 
emulation)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#42: 
new file mode 100644

total: 0 errors, 1 warnings, 1089 lines checked

Patch 27/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
28/29 Checking commit 010f970dbd94 (Hexagon (tests/tcg/hexagon) TCG tests)
ERROR: line over 90 characters
#32: FILE: tests/tcg/configure.sh:99:
+    
alpha|cris|hexagon|hppa|i386|lm32|microblaze|microblazeel|m68k|openrisc|riscv64|s390x|sh4|sparc64)

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#37: 
new file mode 100644

total: 1 errors, 1 warnings, 2728 lines checked

Patch 28/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

29/29 Checking commit 07b76543a655 (Hexagon build infrastructure)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#39: 
new file mode 100644

WARNING: line over 80 characters
#74: FILE: scripts/qemu-binfmt-conf.sh:139:
+hexagon_magic='\x7fELF\x01\x01\x01\x00\x00\x00\x00\x00\x00\x00\x00\x00\x02\x00\xa4\x00'

ERROR: line over 90 characters
#75: FILE: scripts/qemu-binfmt-conf.sh:140:
+hexagon_mask='\xff\xff\xff\xff\xff\xff\xff\x00\xff\xff\xff\xff\xff\xff\xff\xff\xfe\xff\xff\xff'

total: 1 errors, 2 warnings, 223 lines checked

Patch 29/29 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
1601314138-9930-1-git-send-email-tsimpson@quicinc.com/testing.checkpatch/?type=message">http://patchew.org/logs/1601314138-9930-1-git-send-email-tsimpson@quicinc.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
reply via email to
[Prev in Thread] Current Thread [Next in Thread]