Re: [RFC PATCH v4 00/29] Hexagon patch series

[Brad Smith]

On 9/29/2020 1:01 PM, Philippe Mathieu-Daudé wrote:
> On 9/29/20 5:53 PM, Taylor Simpson wrote:
> > > -----Original Message-----
> > > From: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com> On
> > > Behalf Of Philippe Mathieu-Daudé
> > > Sent: Tuesday, September 29, 2020 6:22 AM
> > > To: Taylor Simpson <tsimpson@quicinc.com>; qemu-devel@nongnu.org
> > > Cc: ale@rev.ng; riku.voipio@iki.fi; richard.henderson@linaro.org;
> > > laurent@vivier.eu; aleksandar.m.mail@gmail.com
> > > Subject: Re: [RFC PATCH v4 00/29] Hexagon patch series
> > >
> > > cc1: all warnings being treated as errors
> > > make: *** [Makefile.ninja:638:
> > > libqemu-hexagon-linux-user.fa.p/target_hexagon_decode.c.o] Error 1
> > >
> > > $ gcc --version
> > > gcc (GCC) 10.2.1 20200723 (Red Hat 10.2.1-1)
> > Thanks for all your feedback.  I really appreciate it and will make the changes 
> > you mentioned.
> No problem, I also appreciate the effort you did to address all
> of the previous issues :)
>
> > I'm using an older GCC that doesn't have these errors.  Is this the version of 
> > GCC that is recommended (mandated?) for building qemu?
> QEMU aims to support the 2 latest releases of supported distributions.
>  From time to time a brave developer look at the different versions
> packaged and make some cleanup in the code base. It used to be tedious,
> now that repology.org exists it is a bit easier.
>
> The last effort is from Thomas, see commit efc6c070aca:
>
>      The supported distributions use the following version
>      of GCC:
>
>            RHEL-7: 4.8.5
>            Debian (Stretch): 6.3.0
>            Debian (Jessie): 4.8.4
>            OpenBSD (ports): 4.9.4

OpenBSD as of 6.6 uses GCC 8.3.0 for our ports-gcc.

>            FreeBSD (ports): 8.2.0
>            OpenSUSE Leap 15: 7.3.1
>            Ubuntu (Xenial): 5.3.1
>            macOS (Homebrew): 8.2.0
>
>      So we can safely assume GCC 4.8 these days.
FreeBSD and OpenBSD nowadays use Clang for the (system) compiler.
> This is the "mandated" compiler version.
>
>
> QEMU has some CI jobs, see:
> https://wiki.qemu.org/Testing/CI
>
> You can use most of them by opening GitLab and Travis/Cirrus
> (for GitHub, which you already use).
>
> GitLab will become our "gating CI" soon, so your series is
> expected to pass all the GitLab jobs. IIRC running the tests
> is as easy as register and push your branch to your account.
>
> > PS  You were right about Richard recommending const.  It's already on my TODO 
> > list from his review 😉
> =)
>
> Regards,
>
> Phil.
>
> > Thanks,
> > Taylor