Re: [PATCH 00/19] target/mips: Boring code reordering

[no-reply]

Patchew URL: 20201206233949.3783184-1-f4bug@amsat.org/">https://patchew.org/QEMU/20201206233949.3783184-1-f4bug@amsat.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: 20201206233949.3783184-1-f4bug@amsat.org
Subject: [PATCH 00/19] target/mips: Boring code reordering

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]         patchew/20201206233949.3783184-1-f4bug@amsat.org -> 
patchew/20201206233949.3783184-1-f4bug@amsat.org
Switched to a new branch 'test'
5955800 target/mips: Only build TCG code when CONFIG_TCG is set
74fb03f target/mips: Restrict some TCG specific CPUClass handlers
1da507c target/mips: Rename translate_init.c as cpu-defs.c
f8b846e target/mips: Inline cpu_mips_realize_env() in mips_cpu_realizefn()
68eb53c target/mips: Move cpu definitions, reset() and realize() to cpu.c
9416a38 target/mips: Move mmu_init() functions to tlb_helper.c
730ab18 target/mips: Fix code style for checkpatch.pl
1c460f4 target/mips: Rename helper.c as tlb_helper.c
9325849 target/mips: Extract common helpers from helper.c to common_helper.c
aacb03c target/mips: Add !CONFIG_USER_ONLY comment after #endif
301d3f7 target/mips: Move mips_cpu_add_definition() from helper.c to cpu.c
518b46c target/mips: Extract cpu_supports*/cpu_set* translate.c
3a9ee45 target/mips: Include "exec/memattrs.h" in 'internal.h'
06e88ca target/mips: Remove unused headers from kvm.c
97f7fd0 target/mips: Remove unused headers from op_helper.c
6a9df4d target/mips: Remove unused headers from cp0_helper.c
b97a6c1b target/mips: Remove unused headers from fpu_helper.c
a6de350 target/mips: Remove unused headers from translate.c
eeb48e2 hw/mips: Move address translation helpers to target/mips/

=== OUTPUT BEGIN ===
1/19 Checking commit eeb48e24ca66 (hw/mips: Move address translation helpers to 
target/mips/)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#60: 
rename from hw/mips/addr.c

total: 0 errors, 1 warnings, 63 lines checked

Patch 1/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/19 Checking commit a6de350699a4 (target/mips: Remove unused headers from 
translate.c)
3/19 Checking commit b97a6c1bc3ca (target/mips: Remove unused headers from 
fpu_helper.c)
4/19 Checking commit 6a9df4de3a97 (target/mips: Remove unused headers from 
cp0_helper.c)
5/19 Checking commit 97f7fd0c4202 (target/mips: Remove unused headers from 
op_helper.c)
6/19 Checking commit 06e88ca591f6 (target/mips: Remove unused headers from 
kvm.c)
7/19 Checking commit 3a9ee45ad452 (target/mips: Include "exec/memattrs.h" in 
'internal.h')
8/19 Checking commit 518b46c99f1a (target/mips: Extract cpu_supports*/cpu_set* 
translate.c)
9/19 Checking commit 301d3f7162f6 (target/mips: Move mips_cpu_add_definition() 
from helper.c to cpu.c)
10/19 Checking commit aacb03c8af58 (target/mips: Add !CONFIG_USER_ONLY comment 
after #endif)
11/19 Checking commit 93258497b42f (target/mips: Extract common helpers from 
helper.c to common_helper.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

ERROR: space prohibited after that '&' (ctx:WxW)
#61: FILE: target/mips/common_helper.c:42:
+    cu = (v >> CP0St_CU0) & 0xf;
                           ^

ERROR: space prohibited after that '&' (ctx:WxW)
#62: FILE: target/mips/common_helper.c:43:
+    mx = (v >> CP0St_MX) & 0x1;
                          ^

ERROR: space prohibited after that '&' (ctx:WxW)
#63: FILE: target/mips/common_helper.c:44:
+    ksu = (v >> CP0St_KSU) & 0x3;
                            ^

ERROR: space prohibited after that '&' (ctx:WxW)
#90: FILE: target/mips/common_helper.c:71:
+        uint32_t ksux = (1 << CP0St_KX) & val;
                                         ^

ERROR: space prohibited after that '&' (ctx:WxW)
#98: FILE: target/mips/common_helper.c:79:
+        mask &= ~(((1 << CP0St_SR) | (1 << CP0St_NMI)) & val);
                                                        ^

ERROR: space prohibited after that '&' (ctx:WxW)
#125: FILE: target/mips/common_helper.c:106:
+        mask &= ~((1 << CP0Ca_WP) & val);
                                   ^

ERROR: space prohibited after that '&' (ctx:WxW)
#130: FILE: target/mips/common_helper.c:111:
+    if ((old ^ env->CP0_Cause) & (1 << CP0Ca_DC)) {
                                ^

ERROR: space prohibited after that '&' (ctx:WxW)
#140: FILE: target/mips/common_helper.c:121:
+        if ((old ^ env->CP0_Cause) & (1 << (CP0Ca_IP + i))) {
                                    ^

total: 8 errors, 1 warnings, 343 lines checked

Patch 11/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

12/19 Checking commit 1c460f4d205c (target/mips: Rename helper.c as 
tlb_helper.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#31: 
rename from target/mips/helper.c

total: 0 errors, 1 warnings, 17 lines checked

Patch 12/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
13/19 Checking commit 730ab184536c (target/mips: Fix code style for 
checkpatch.pl)
14/19 Checking commit 9416a385f0e7 (target/mips: Move mmu_init() functions to 
tlb_helper.c)
15/19 Checking commit 68eb53c2ca47 (target/mips: Move cpu definitions, reset() 
and realize() to cpu.c)
16/19 Checking commit f8b846e71622 (target/mips: Inline cpu_mips_realize_env() 
in mips_cpu_realizefn())
17/19 Checking commit 1da507c9dd58 (target/mips: Rename translate_init.c as 
cpu-defs.c)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
rename from target/mips/translate_init.c.inc

total: 0 errors, 1 warnings, 32 lines checked

Patch 17/19 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
18/19 Checking commit 74fb03fbc278 (target/mips: Restrict some TCG specific 
CPUClass handlers)
19/19 Checking commit 59558002f58b (target/mips: Only build TCG code when 
CONFIG_TCG is set)
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
20201206233949.3783184-1-f4bug@amsat.org/testing.checkpatch/?type=message">http://patchew.org/logs/20201206233949.3783184-1-f4bug@amsat.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com