Re: [RFC v9 19/32] cpu: Move cpu_exec_* to tcg_ops

[Claudio Fontana]

On 12/9/20 10:28 AM, Philippe Mathieu-Daudé wrote:
> On 12/8/20 8:48 PM, Claudio Fontana wrote:
>> From: Eduardo Habkost <ehabkost@redhat.com>
>>
>> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>> [claudio: wrapped in CONFIG_TCG]
>> Signed-off-by: Claudio Fontana <cfontana@suse.de>
>> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
>> ---
> ...
> 
>> diff --git a/include/hw/core/tcg-cpu-ops.h b/include/hw/core/tcg-cpu-ops.h
>> index 109291ac52..e12f32919b 100644
>> --- a/include/hw/core/tcg-cpu-ops.h
>> +++ b/include/hw/core/tcg-cpu-ops.h
>> @@ -10,6 +10,9 @@
>>  #ifndef TCG_CPU_OPS_H
>>  #define TCG_CPU_OPS_H
>>  
>> +/**
>> + * struct TcgCpuOperations: TCG operations specific to a CPU class
>> + */
> 
> Oh, added back ;)


Fixed this "back and forth", thanks!

Claudio


> 
>>  typedef struct TcgCpuOperations {
>>      /**
>>       * @initialize: Initalize TCG state
>> @@ -28,6 +31,12 @@ typedef struct TcgCpuOperations {
>>       * @set_pc(tb->pc).
>>       */
>>      void (*synchronize_from_tb)(CPUState *cpu, struct TranslationBlock *tb);
>> +    /** @cpu_exec_enter: Callback for cpu_exec preparation */
>> +    void (*cpu_exec_enter)(CPUState *cpu);
>> +    /** @cpu_exec_exit: Callback for cpu_exec cleanup */
>> +    void (*cpu_exec_exit)(CPUState *cpu);
>> +    /** @cpu_exec_interrupt: Callback for processing interrupts in cpu_exec 
>> */
>> +    bool (*cpu_exec_interrupt)(CPUState *cpu, int interrupt_request);
>>  } TcgCpuOperations;
>