Re: [RFC v9 24/32] cpu: move cc->transaction_failed to tcg_ops

[Eduardo Habkost]

On Wed, Dec 09, 2020 at 03:43:54PM +0100, Claudio Fontana wrote:
> On 12/9/20 10:31 AM, Philippe Mathieu-Daudé wrote:
> > On 12/8/20 8:48 PM, Claudio Fontana wrote:
> >> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> >> ---
> > ...
> >> diff --git a/include/hw/core/tcg-cpu-ops.h b/include/hw/core/tcg-cpu-ops.h
> >> index 6b9b72e785..0cc0927738 100644
> >> --- a/include/hw/core/tcg-cpu-ops.h
> >> +++ b/include/hw/core/tcg-cpu-ops.h
> > 
> > Missing (for MemTxAttrs/MemTxResult):
> > 
> >   #include "exec/memattrs.h"
> 
> 
> right, this is included only from cpu.h though, which already does it, should 
> we still repeat the include here?

It doesn't hurt, and may save some headache in the future.  A .c
file should be able to include tcg-cpu-ops.h directly if
necessary.

-- 
Eduardo