[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough
From: |
Thomas Huth |
Subject: |
[PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough |
Date: |
Fri, 11 Dec 2020 16:24:14 +0100 |
Coverity is already reporting switch-case statements where code
can fall through from one case to another without a proper comment
(since this could indicate a missing "break" and thus a bug).
However, it's cumbersome to fix these issues after they have been
merged already, it would be better if the author of the code would
already take care of this when writing the patch. Fortunately,
GCC and Clang can already warn about those code spots, too.
So let's fix our remaining statements that fall through without
a proper comment, so we can finally turn on -Wimplicit-fallthrough
for all compilation runs.
Chen Qun (6):
hw/timer/renesas_tmr: silence the compiler warnings
target/i386: silence the compiler warnings in gen_shiftd_rm_T1
hw/intc/arm_gicv3_kvm: silence the compiler warnings
accel/tcg/user-exec: silence the compiler warnings
target/sparc/translate: silence the compiler warnings
target/sparc/win_helper: silence the compiler warnings
Thomas Huth (6):
disas/libvixl: Fix fall-through annotation for GCC >= 7
target/unicore32/translate: Add missing fallthrough annotations
hw/rtc/twl92230: Silence warnings about missing fallthrough statements
tcg/optimize: Add fallthrough annotations
tests/fp: Do not emit implicit-fallthrough warnings in the softfloat
tests
configure: Compile with -Wimplicit-fallthrough=2
accel/tcg/user-exec.c | 3 +-
configure | 1 +
disas/libvixl/vixl/a64/disasm-a64.cc | 4 +++
disas/libvixl/vixl/globals.h | 6 ++--
hw/intc/arm_gicv3_kvm.c | 8 ++++++
hw/rtc/twl92230.c | 43 +++++++++-------------------
hw/timer/renesas_tmr.c | 1 +
include/qemu/compiler.h | 11 +++++++
target/i386/translate.c | 7 +++--
target/sparc/translate.c | 2 +-
target/sparc/win_helper.c | 2 +-
target/unicore32/translate.c | 2 ++
tcg/optimize.c | 4 +++
tests/fp/meson.build | 2 ++
14 files changed, 59 insertions(+), 37 deletions(-)
--
2.27.0
- [PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough,
Thomas Huth <=
- [PATCH 01/12] disas/libvixl: Fix fall-through annotation for GCC >= 7, Thomas Huth, 2020/12/11
- [PATCH 03/12] hw/rtc/twl92230: Silence warnings about missing fallthrough statements, Thomas Huth, 2020/12/11
- [PATCH 02/12] target/unicore32/translate: Add missing fallthrough annotations, Thomas Huth, 2020/12/11
- [PATCH 04/12] hw/timer/renesas_tmr: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 05/12] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, Thomas Huth, 2020/12/11
- [PATCH 07/12] accel/tcg/user-exec: silence the compiler warnings, Thomas Huth, 2020/12/11