[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/12] disas/libvixl: Fix fall-through annotation for GCC >=
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 01/12] disas/libvixl: Fix fall-through annotation for GCC >= 7 |
|
Date: |
Fri, 11 Dec 2020 15:35:44 +0000 |
On Fri, 11 Dec 2020 at 15:24, Thomas Huth <thuth@redhat.com> wrote:
>
> For compiling with -Wimplicit-fallthrough we need to fix the
> fallthrough annotations in the libvixl code. This is based on
> the following upstream vixl commit by Martyn Capewell:
>
> https://git.linaro.org/arm/vixl.git/commit/?id=de326f850f736c3a337
>
> "GCC 7 enables switch/case fallthrough checking, but this fails in
> VIXL, because the annotation we use is Clang specific.
>
> Also, fix a missing annotation in the disassembler."
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Let's not block -Wimplicit-fallthrough on either updating
our vixl or deciding what we're doing with disassembly more
generally...
thanks
-- PMM
- [PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough, Thomas Huth, 2020/12/11
- [PATCH 01/12] disas/libvixl: Fix fall-through annotation for GCC >= 7, Thomas Huth, 2020/12/11
- Re: [PATCH 01/12] disas/libvixl: Fix fall-through annotation for GCC >= 7,
Peter Maydell <=
- [PATCH 03/12] hw/rtc/twl92230: Silence warnings about missing fallthrough statements, Thomas Huth, 2020/12/11
- [PATCH 02/12] target/unicore32/translate: Add missing fallthrough annotations, Thomas Huth, 2020/12/11
- [PATCH 04/12] hw/timer/renesas_tmr: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 05/12] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, Thomas Huth, 2020/12/11
- [PATCH 07/12] accel/tcg/user-exec: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 06/12] hw/intc/arm_gicv3_kvm: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 08/12] target/sparc/translate: silence the compiler warnings, Thomas Huth, 2020/12/11