[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 12/12] configure: Compile with -Wimplicit-fallthrough=2
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH 12/12] configure: Compile with -Wimplicit-fallthrough=2 |
|
Date: |
Fri, 11 Dec 2020 15:42:30 +0000 |
On Fri, 11 Dec 2020 at 15:24, Thomas Huth <thuth@redhat.com> wrote:
>
> Coverity always complains about switch-case statements that fall through
> the next one when there is no comment in between - which could indicate
> a forgotten "break" statement. Instead of handling these issues after
> they have been committed, it would be better to avoid them in the build
> process already. Thus let's enable the -Wimplicit-fallthrough warning now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure b/configure
> index 18c26e0389..dc2bc3c2f0 100755
> --- a/configure
> +++ b/configure
> @@ -2007,6 +2007,7 @@ add_to warn_flags -Wempty-body
> add_to warn_flags -Wnested-externs
> add_to warn_flags -Wendif-labels
> add_to warn_flags -Wexpansion-to-defined
> +add_to warn_flags -Wimplicit-fallthrough=2
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Maybe mention in the commit message why =2 is our preference ?
thanks
-- PMM
- [PATCH 04/12] hw/timer/renesas_tmr: silence the compiler warnings, (continued)
- [PATCH 04/12] hw/timer/renesas_tmr: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 05/12] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, Thomas Huth, 2020/12/11
- [PATCH 07/12] accel/tcg/user-exec: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 06/12] hw/intc/arm_gicv3_kvm: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 08/12] target/sparc/translate: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 10/12] tcg/optimize: Add fallthrough annotations, Thomas Huth, 2020/12/11
- [PATCH 12/12] configure: Compile with -Wimplicit-fallthrough=2, Thomas Huth, 2020/12/11
- [PATCH 11/12] tests/fp: Do not emit implicit-fallthrough warnings in the softfloat tests, Thomas Huth, 2020/12/11
- [PATCH 09/12] target/sparc/win_helper: silence the compiler warnings, Thomas Huth, 2020/12/11
- Re: [PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough, Thomas Huth, 2020/12/11
- Re: [PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough, no-reply, 2020/12/11