[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [PATCH 11/12] tests/fp: Do not emit implicit-fallthrough warnings in
From: |
Chenqun (kuhn) |
Subject: |
RE: [PATCH 11/12] tests/fp: Do not emit implicit-fallthrough warnings in the softfloat tests |
Date: |
Sat, 12 Dec 2020 07:58:35 +0000 |
> -----Original Message-----
> From: Thomas Huth [mailto:thuth@redhat.com]
> Sent: Friday, December 11, 2020 11:24 PM
> To: Peter Maydell <peter.maydell@linaro.org>; qemu-devel@nongnu.org
> Cc: Chenqun (kuhn) <kuhn.chenqun@huawei.com>; Richard Henderson
> <richard.henderson@linaro.org>; Paolo Bonzini <pbonzini@redhat.com>
> Subject: [PATCH 11/12] tests/fp: Do not emit implicit-fallthrough warnings in
> the softfloat tests
>
> The softfloat tests are external repositories, so we do not care about
> implicit
> fallthrough warnings in this code.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
Reviewed-by: Chen Qun <kuhn.chenqun@huawei.com>
The warnings are frequently generated for files in this directory.
This is a good solution for the warnings.
Thanks,
Chen Qun
> tests/fp/meson.build | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/fp/meson.build b/tests/fp/meson.build index
> 3d4fb00f9d..8d739c4d59 100644
> --- a/tests/fp/meson.build
> +++ b/tests/fp/meson.build
> @@ -27,6 +27,7 @@ tfdir = 'berkeley-testfloat-3/source'
> sfinc = include_directories(sfdir / 'include', sfspedir)
>
> tfcflags = [
> + '-Wno-implicit-fallthrough',
> '-Wno-strict-prototypes',
> '-Wno-unknown-pragmas',
> '-Wno-uninitialized',
> @@ -209,6 +210,7 @@ libtestfloat = static_library(
> )
>
> sfcflags = [
> + '-Wno-implicit-fallthrough',
> '-Wno-missing-prototypes',
> '-Wno-redundant-decls',
> '-Wno-return-type',
> --
> 2.27.0
- [PATCH 05/12] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, (continued)
- [PATCH 05/12] target/i386: silence the compiler warnings in gen_shiftd_rm_T1, Thomas Huth, 2020/12/11
- [PATCH 07/12] accel/tcg/user-exec: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 06/12] hw/intc/arm_gicv3_kvm: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 08/12] target/sparc/translate: silence the compiler warnings, Thomas Huth, 2020/12/11
- [PATCH 10/12] tcg/optimize: Add fallthrough annotations, Thomas Huth, 2020/12/11
- [PATCH 12/12] configure: Compile with -Wimplicit-fallthrough=2, Thomas Huth, 2020/12/11
- [PATCH 11/12] tests/fp: Do not emit implicit-fallthrough warnings in the softfloat tests, Thomas Huth, 2020/12/11
- [PATCH 09/12] target/sparc/win_helper: silence the compiler warnings, Thomas Huth, 2020/12/11
- Re: [PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough, Thomas Huth, 2020/12/11
- Re: [PATCH 00/12] Compile QEMU with -Wimplicit-fallthrough, no-reply, 2020/12/11