[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 05/32] sparc: Check dev->realized at sparc_set_nwindows()
From: |
Eduardo Habkost |
Subject: |
[PATCH v4 05/32] sparc: Check dev->realized at sparc_set_nwindows() |
Date: |
Fri, 11 Dec 2020 17:05:02 -0500 |
sparc_set_nwindows() is one of the very few property setters that
don't check dev->realized, and there's no reason for it to be
special. Check dev->realized like the other setters.
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: Artyom Tarasenko <atar4qemu@gmail.com>
Cc: qemu-devel@nongnu.org
---
target/sparc/cpu.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
index 701e794eac..6a3299041f 100644
--- a/target/sparc/cpu.c
+++ b/target/sparc/cpu.c
@@ -798,11 +798,17 @@ static void sparc_get_nwindows(Object *obj, Visitor *v,
const char *name,
static void sparc_set_nwindows(Object *obj, Visitor *v, const char *name,
void *opaque, Error **errp)
{
+ DeviceState *dev = DEVICE(obj);
const int64_t min = MIN_NWINDOWS;
const int64_t max = MAX_NWINDOWS;
SPARCCPU *cpu = SPARC_CPU(obj);
int64_t value;
+ if (dev->realized) {
+ qdev_prop_set_after_realize(dev, name, errp);
+ return;
+ }
+
if (!visit_type_int(v, name, &value, errp)) {
return;
}
--
2.28.0
- [PATCH v4 00/32] qdev property code cleanup, Eduardo Habkost, 2020/12/11
- [PATCH v4 02/32] cpu: Move cpu_common_props to hw/core/cpu.c, Eduardo Habkost, 2020/12/11
- [PATCH v4 01/32] cs4231: Get rid of empty property array, Eduardo Habkost, 2020/12/11
- [PATCH v4 04/32] qdev: Check dev->realized at set_size(), Eduardo Habkost, 2020/12/11
- [PATCH v4 03/32] qdev: Move property code to qdev-properties.[ch], Eduardo Habkost, 2020/12/11
- [PATCH v4 06/32] qdev: Don't use dev->id on set_size32() error message, Eduardo Habkost, 2020/12/11
- [PATCH v4 05/32] sparc: Check dev->realized at sparc_set_nwindows(),
Eduardo Habkost <=
- [PATCH v4 07/32] qdev: Make PropertyInfo.print method get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 08/32] qdev: Make bit_prop_set() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 09/32] qdev: Make qdev_get_prop_ptr() get Object* arg, Eduardo Habkost, 2020/12/11
- [PATCH v4 11/32] qdev: Make check_prop_still_unset() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 10/32] qdev: Make qdev_find_global_prop() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 12/32] qdev: Make error_set_from_qdev_prop_error() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 13/32] qdev: Make qdev_propinfo_get_uint16() static, Eduardo Habkost, 2020/12/11
- [PATCH v4 14/32] qdev: Move UUID property to qdev-properties-system.c, Eduardo Habkost, 2020/12/11