[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 13/32] qdev: Make qdev_propinfo_get_uint16() static
From: |
Eduardo Habkost |
Subject: |
[PATCH v4 13/32] qdev: Make qdev_propinfo_get_uint16() static |
Date: |
Fri, 11 Dec 2020 17:05:10 -0500 |
There are no users of the function outside qdev-properties.c.
Make function static and rename it to get_uint16().
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
hw/core/qdev-prop-internal.h | 2 --
hw/core/qdev-properties.c | 6 +++---
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/hw/core/qdev-prop-internal.h b/hw/core/qdev-prop-internal.h
index 9cf5cc1d51..d7b77844fe 100644
--- a/hw/core/qdev-prop-internal.h
+++ b/hw/core/qdev-prop-internal.h
@@ -20,8 +20,6 @@ void qdev_propinfo_set_default_value_int(ObjectProperty *op,
void qdev_propinfo_set_default_value_uint(ObjectProperty *op,
const Property *prop);
-void qdev_propinfo_get_uint16(Object *obj, Visitor *v, const char *name,
- void *opaque, Error **errp);
void qdev_propinfo_get_int32(Object *obj, Visitor *v, const char *name,
void *opaque, Error **errp);
void qdev_propinfo_get_size32(Object *obj, Visitor *v, const char *name,
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index 5e010afdb8..765e916c23 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -278,8 +278,8 @@ const PropertyInfo qdev_prop_uint8 = {
/* --- 16bit integer --- */
-void qdev_propinfo_get_uint16(Object *obj, Visitor *v, const char *name,
- void *opaque, Error **errp)
+static void get_uint16(Object *obj, Visitor *v, const char *name,
+ void *opaque, Error **errp)
{
Property *prop = opaque;
uint16_t *ptr = qdev_get_prop_ptr(obj, prop);
@@ -304,7 +304,7 @@ static void set_uint16(Object *obj, Visitor *v, const char
*name,
const PropertyInfo qdev_prop_uint16 = {
.name = "uint16",
- .get = qdev_propinfo_get_uint16,
+ .get = get_uint16,
.set = set_uint16,
.set_default_value = qdev_propinfo_set_default_value_uint,
};
--
2.28.0
- [PATCH v4 06/32] qdev: Don't use dev->id on set_size32() error message, (continued)
- [PATCH v4 06/32] qdev: Don't use dev->id on set_size32() error message, Eduardo Habkost, 2020/12/11
- [PATCH v4 05/32] sparc: Check dev->realized at sparc_set_nwindows(), Eduardo Habkost, 2020/12/11
- [PATCH v4 07/32] qdev: Make PropertyInfo.print method get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 08/32] qdev: Make bit_prop_set() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 09/32] qdev: Make qdev_get_prop_ptr() get Object* arg, Eduardo Habkost, 2020/12/11
- [PATCH v4 11/32] qdev: Make check_prop_still_unset() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 10/32] qdev: Make qdev_find_global_prop() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 12/32] qdev: Make error_set_from_qdev_prop_error() get Object* argument, Eduardo Habkost, 2020/12/11
- [PATCH v4 13/32] qdev: Make qdev_propinfo_get_uint16() static,
Eduardo Habkost <=
- [PATCH v4 14/32] qdev: Move UUID property to qdev-properties-system.c, Eduardo Habkost, 2020/12/11
- [PATCH v4 16/32] qdev: Reuse DEFINE_PROP in all DEFINE_PROP_* macros, Eduardo Habkost, 2020/12/11
- [PATCH v4 17/32] sparc: Use DEFINE_PROP for nwindows property, Eduardo Habkost, 2020/12/11
- Re: [PATCH v4 17/32] sparc: Use DEFINE_PROP for nwindows property, Mark Cave-Ayland, 2020/12/15
- [PATCH v4 18/32] qdev: Get just property name at error_set_from_qdev_prop_error(), Eduardo Habkost, 2020/12/11