qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 17/32] sparc: Use DEFINE_PROP for nwindows property


From: Mark Cave-Ayland
Subject: Re: [PATCH v4 17/32] sparc: Use DEFINE_PROP for nwindows property
Date: Tue, 15 Dec 2020 11:52:31 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1

On 11/12/2020 22:05, Eduardo Habkost wrote:

Use the DEFINE_PROP macro (which will set extra fields in the
struct) instead of initializing a Property struct manually.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
This is a new patch added in v2 of the series
---
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: Artyom Tarasenko <atar4qemu@gmail.com>
Cc: qemu-devel@nongnu.org
---
  target/sparc/cpu.c | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/target/sparc/cpu.c b/target/sparc/cpu.c
index 6a3299041f..92534bcd18 100644
--- a/target/sparc/cpu.c
+++ b/target/sparc/cpu.c
@@ -848,7 +848,8 @@ static Property sparc_cpu_properties[] = {
                           qdev_prop_uint64, target_ulong),
      DEFINE_PROP_UINT32("fpu-version", SPARCCPU, env.def.fpu_version, 0),
      DEFINE_PROP_UINT32("mmu-version", SPARCCPU, env.def.mmu_version, 0),
-    { .name  = "nwindows", .info  = &qdev_prop_nwindows },
+    DEFINE_PROP("nwindows",     SPARCCPU, env.def.nwindows,
+                qdev_prop_nwindows, uint32_t),
      DEFINE_PROP_END_OF_LIST()
  };

Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>

FWIW as my bandwidth can be intermittent at times, I'm generally happy to give an implicit go-ahead for merging the QOM/QDEV improvements since IMO the benefits far outweigh any potential problems. So if you don't hear from me then I'm happy for you to assume that any SPARC-related changes in this area are implicitly okay to merge :)


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]