[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops |
|
Date: |
Mon, 14 Dec 2020 14:10:29 -0500 |
On Sat, Dec 12, 2020 at 04:55:23PM +0100, Claudio Fontana wrote:
> From: Eduardo Habkost <ehabkost@redhat.com>
>
> since tcg_cpu_ops.h is only included in cpu.h,
> and as a standalone header it is not really useful,
> as tcg_cpu_ops.h starts requiring cpu.h defines,
> enums, etc, as well as (later on in the series),
> additional definitions coming from memattr.h.
>
> Therefore rename it to tcg_cpu_ops.h.inc, to warn
> any potential user that this file is not a standalone
> header, but rather a partition of cpu.h that is
> included conditionally if CONFIG_TCG is true.
What's the benefit of moving definitions to a separate file, if
the new file is not a standalone header?
If moving the definitions to a separate header is going to
require too much work, it's completely OK to keep them in cpu.h
by now, and try to move them later.
I'm worried that the scope of this series is growing too much,
and discussion/review of additional changes in each new version
is preventing us from merging the original changes where we
already had some consensus.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
>
> [claudio: wrapped in CONFIG_TCG, renamed .h to .inc]
> Signed-off-by: Claudio Fontana <cfontana@suse.de>
> ---
> include/hw/core/cpu.h | 10 +---------
> accel/tcg/cpu-exec.c | 4 ++--
> target/arm/cpu.c | 4 +++-
> target/avr/cpu.c | 2 +-
> target/hppa/cpu.c | 2 +-
> target/i386/tcg/tcg-cpu.c | 2 +-
> target/microblaze/cpu.c | 2 +-
> target/mips/cpu.c | 4 +++-
> target/riscv/cpu.c | 2 +-
> target/rx/cpu.c | 2 +-
> target/sh4/cpu.c | 2 +-
> target/sparc/cpu.c | 2 +-
> target/tricore/cpu.c | 2 +-
> include/hw/core/{tcg-cpu-ops.h => tcg-cpu-ops.h.inc} | 10 ++++++++++
> 14 files changed, 28 insertions(+), 22 deletions(-)
> rename include/hw/core/{tcg-cpu-ops.h => tcg-cpu-ops.h.inc} (55%)
[...]
--
Eduardo
- [PATCH v12 00/23] i386 cleanup PART 1, Claudio Fontana, 2020/12/12
- [PATCH v12 17/23] cpu: Move cpu_exec_* to tcg_ops, Claudio Fontana, 2020/12/12
- [PATCH v12 06/23] i386: move cpu dump out of helper.c into cpu-dump.c, Claudio Fontana, 2020/12/12
- [PATCH v12 04/23] i386: hvf: remove stale MAINTAINERS entry for old hvf stubs, Claudio Fontana, 2020/12/12
- [PATCH v12 05/23] i386: move TCG accel files into tcg/, Claudio Fontana, 2020/12/12
- [PATCH v12 15/23] accel/tcg: split TCG-only code from cpu_exec_realizefn, Claudio Fontana, 2020/12/12
- [PATCH v12 14/23] target/riscv: remove CONFIG_TCG, as it is always TCG, Claudio Fontana, 2020/12/12
- [PATCH v12 11/23] tcg: Make CPUClass.debug_excp_handler optional, Claudio Fontana, 2020/12/12
- [PATCH v12 01/23] i386: move kvm accel files into kvm/, Claudio Fontana, 2020/12/12
- [PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops, Claudio Fontana, 2020/12/12
[PATCH v12 20/23] target/arm: do not use cc->do_interrupt for KVM directly, Claudio Fontana, 2020/12/12
[PATCH v12 19/23] cpu: Move debug_excp_handler to tcg_ops, Claudio Fontana, 2020/12/12
[PATCH v12 09/23] tcg: cpu_exec_{enter,exit} helpers, Claudio Fontana, 2020/12/12
[PATCH v12 10/23] tcg: make CPUClass.cpu_exec_* optional, Claudio Fontana, 2020/12/12
[PATCH v12 08/23] i386: tcg: remove inline from cpu_load_eflags, Claudio Fontana, 2020/12/12