[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops
|
From: |
Claudio Fontana |
|
Subject: |
Re: [PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops |
|
Date: |
Wed, 16 Dec 2020 09:44:14 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 |
On 12/14/20 10:56 PM, Philippe Mathieu-Daudé wrote:
> Hi Claudio, Eduardo.
>
> On 12/14/20 8:10 PM, Eduardo Habkost wrote:
>> On Sat, Dec 12, 2020 at 04:55:23PM +0100, Claudio Fontana wrote:
>>> From: Eduardo Habkost <ehabkost@redhat.com>
>>>
>>> since tcg_cpu_ops.h is only included in cpu.h,
>>> and as a standalone header it is not really useful,
>>> as tcg_cpu_ops.h starts requiring cpu.h defines,
>>> enums, etc, as well as (later on in the series),
>>> additional definitions coming from memattr.h.
>>>
>>> Therefore rename it to tcg_cpu_ops.h.inc, to warn
>>> any potential user that this file is not a standalone
>>> header, but rather a partition of cpu.h that is
>>> included conditionally if CONFIG_TCG is true.
>>
>> What's the benefit of moving definitions to a separate file, if
>> the new file is not a standalone header?
>
the benefit is avoiding a 100 line ifdef CONFIG_TCG, and already separating out
what is tcg-specific and what isn't,
but if this is a problem we can avoid that, and revisit later on.
> Claudio, I haven't been following every respin. If you did that
> change just to please me then the circular dependency remarked by
> Richard, then if it simplify the series I'm OK if you have to
> remove the includes.
Richard, From the answer of Philippe and Eduardo I think they are not ok with
.h.inc,
I think the option of just putting everything in cpu.h was ok with you,
should I go with that?
Thanks,
Claudio
>
> Eduardo, if you are happy with patches 1-8 (x86 specific), maybe
> you can queue them already. The rest is more TCG generic and
> will likely go via Richard/Paolo trees IMO.
>
>>
>> If moving the definitions to a separate header is going to
>> require too much work, it's completely OK to keep them in cpu.h
>> by now, and try to move them later.
>>
>> I'm worried that the scope of this series is growing too much,
>> and discussion/review of additional changes in each new version
>> is preventing us from merging the original changes where we
>> already had some consensus.
>
- [PATCH v12 05/23] i386: move TCG accel files into tcg/, (continued)
- [PATCH v12 05/23] i386: move TCG accel files into tcg/, Claudio Fontana, 2020/12/12
- [PATCH v12 15/23] accel/tcg: split TCG-only code from cpu_exec_realizefn, Claudio Fontana, 2020/12/12
- [PATCH v12 14/23] target/riscv: remove CONFIG_TCG, as it is always TCG, Claudio Fontana, 2020/12/12
- [PATCH v12 11/23] tcg: Make CPUClass.debug_excp_handler optional, Claudio Fontana, 2020/12/12
- [PATCH v12 01/23] i386: move kvm accel files into kvm/, Claudio Fontana, 2020/12/12
- [PATCH v12 16/23] cpu: Move synchronize_from_tb() to tcg_ops, Claudio Fontana, 2020/12/12
[PATCH v12 20/23] target/arm: do not use cc->do_interrupt for KVM directly, Claudio Fontana, 2020/12/12
[PATCH v12 19/23] cpu: Move debug_excp_handler to tcg_ops, Claudio Fontana, 2020/12/12
[PATCH v12 09/23] tcg: cpu_exec_{enter,exit} helpers, Claudio Fontana, 2020/12/12
[PATCH v12 10/23] tcg: make CPUClass.cpu_exec_* optional, Claudio Fontana, 2020/12/12
[PATCH v12 08/23] i386: tcg: remove inline from cpu_load_eflags, Claudio Fontana, 2020/12/12
[PATCH v12 03/23] i386: move hax accel files into hax/, Claudio Fontana, 2020/12/12
[PATCH v12 22/23] cpu: move cc->transaction_failed to tcg_ops, Claudio Fontana, 2020/12/12
[PATCH v12 18/23] cpu: Move tlb_fill to tcg_ops, Claudio Fontana, 2020/12/12