Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel

From:	John Snow
Subject:	Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel
Date:	Wed, 16 Dec 2020 14:11:35 -0500
User-agent:	Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 12/16/20 4:22 AM, Markus Armbruster wrote:

2. On error with "no source info", don't crash.

    I have my doubts on this one.

    Such an error means the QAPI code generator screwed up, at least in
    theory.  Crashing is only proper.  It gets the screwup fixed.

QAPISemError and friends will also halt the generator and don't produceoutput and will fail tests. They aren't less visible or more ignorablesomehow.

    In practice, errors due to interactions between built-in stuff and
    user-defined stuff could conceivably escape testing.  I can't
    remember such a case offhand.

    Will the "no source info" error be more useful than a crash?
    Possibly.  Will it get the screwup fixed?  Maybe not.

I don't understand this; if it's an error -- there's no QAPI, there's noQEMU. It's definitely getting fixed.

If QAPISourceInfo is primarily used for printing error information, weare already in a situation where the generator is hosed and has wandereditself into a problem that can't be ignored.

There's no additional value in having python crash twice per every crashbecause we have bad types in our error reporting functions.


--js

[Prev in Thread]

Current Thread

[Next in Thread]

Re: [PATCH 04/12] qapi/gen: assert that _start_if is not None in _wrap_ifcond, (continued)
- [PATCH 05/12] qapi/gen: use './builtin' for the built-in module name, John Snow, 2020/12/14
  - Re: [PATCH 05/12] qapi/gen: use './builtin' for the built-in module name, Markus Armbruster, 2020/12/16
    - Re: [PATCH 05/12] qapi/gen: use './builtin' for the built-in module name, John Snow, 2020/12/16
- [PATCH 06/12] qapi/source: Add builtin null-object sentinel, John Snow, 2020/12/14
  - Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel, Markus Armbruster, 2020/12/16
    - Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel, John Snow, 2020/12/16
    - Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel, Markus Armbruster, 2020/12/17
    - Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel, John Snow, 2020/12/18
    - Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel, John Snow <=
    - Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel, Markus Armbruster, 2020/12/17
    - Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel, John Snow, 2020/12/18
- [PATCH 07/12] qapi/gen: write _genc/_genh access shims, John Snow, 2020/12/14
- [PATCH 09/12] qapi/gen: move write method to QAPIGenC, make fname a str, John Snow, 2020/12/14
  - Re: [PATCH 09/12] qapi/gen: move write method to QAPIGenC, make fname a str, Markus Armbruster, 2020/12/16
- [PATCH 10/12] tests/qapi-schema: Add quotes to module name in test output, John Snow, 2020/12/14
- [PATCH 11/12] qapi/schema: Name the builtin module "" instead of None, John Snow, 2020/12/14
  - Re: [PATCH 11/12] qapi/schema: Name the builtin module "" instead of None, Markus Armbruster, 2020/12/16
    - Re: [PATCH 11/12] qapi/schema: Name the builtin module "" instead of None, John Snow, 2020/12/16
    - Re: [PATCH 11/12] qapi/schema: Name the builtin module "" instead of None, Markus Armbruster, 2020/12/17

Prev by Date: Re: [PATCH v2 03/12] target/mips/mips-defs: Use ISA_MIPS32 definition to check Release 1
Next by Date: Re: [PATCH v2 04/12] target/mips/mips-defs: Use ISA_MIPS32R2 definition to check Release 2
Previous by thread: Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel
Next by thread: Re: [PATCH 06/12] qapi/source: Add builtin null-object sentinel
Index(es):
- Date
- Thread