[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] accel: kvm: Fix memory waste under mismatch page size
|
From: |
Peter Xu |
|
Subject: |
Re: [PATCH 1/2] accel: kvm: Fix memory waste under mismatch page size |
|
Date: |
Wed, 16 Dec 2020 15:48:18 -0500 |
On Wed, Dec 16, 2020 at 04:21:17PM +0800, Keqian Zhu wrote:
> One more thing, we should consider whether @start and @size is psize aligned
> (my second
> patch). Do you agree to add assert on them directly?
Yes I think the 2nd patch is okay, but please address Drew's comments.
Returning -EINVAL is the same as abort() currently - it'll just abort() at
kvm_log_clear() instead.
Thanks,
--
Peter Xu