Re: [PATCH] whpx: fix compilation

[Claudio Fontana]

On 12/18/20 9:46 AM, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> When compiling WHPX (on msys2)
> 
> FAILED: libqemu-x86_64-softmmu.fa.p/target_i386_whpx_whpx-all.c.obj
> ../target/i386/whpx/whpx-all.c:29:10: fatal error: whp-dispatch.h: No such 
> file or directory
>    29 | #include "whp-dispatch.h"
>       |          ^~~~~~~~~~~~~~~~
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  include/sysemu/whpx.h | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/include/sysemu/whpx.h b/include/sysemu/whpx.h
> index 9346fd92e9..79ab3d73cf 100644
> --- a/include/sysemu/whpx.h
> +++ b/include/sysemu/whpx.h
> @@ -15,7 +15,9 @@
>  
>  #ifdef CONFIG_WHPX
>  
> -#include "whp-dispatch.h"
> +#include <windows.h>
> +#include <WinHvPlatform.h>
> +#include <WinHvEmulation.h>
>  
>  struct whpx_state {
>      uint64_t mem_quota;
> 

Hi Marc, interesting factoid: cirrus-ci shows "GREEN", screaming all-ok for 
msys2, while the error is present,
and visible only on manual inspection of "Run main".

https://cirrus-ci.com/task/6573590369796096

Maybe something that needs attention CI-wise? Not sure who knows the details 
there, and how to fix it..
Maybe it's my move of whpx code to a subdirectory of target/i386/ that caused 
the breakage?

Ciao,

Claudio