qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] whpx: fix compilation


From: Paolo Bonzini
Subject: Re: [PATCH] whpx: fix compilation
Date: Fri, 18 Dec 2020 14:07:27 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0

You're right that the headers _are_ included in whp-dispatch.h, so yeah they do provide WHV_PARTITION_HANDLE which is the only thing that needs API includes.

But in turn whpx_state is only needed for whpx_apic_in_platform(), so the main issue is that sysemu/whpx.h is exposing unnecessary application details. We can make two changes. First, make whpx_apic_in_platform() a function instead of a macro, so that whpx_state can be moved to a new header whpx-internal.h.

In fact, whp-dispatch.h and the new header can be merged, too. I'll send two patches.

Paolo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]