Re: [PATCH qemu v12] spapr: Implement Open Firmware client interface

[Greg Kurz]

On Mon, 21 Dec 2020 23:06:40 +1100
Alexey Kardashevskiy <aik@ozlabs.ru> wrote:

[...]

> > Thanks for the split. The VOF paths are now clearly identified in
> > the sPAPR code, and well guarded by a check on x-vof. Rest of the
> > patch looks good to me. I gave it a try with a stock fedora 33
> > kernel and initramfs and it booted really fast !
>  >
> > With the checkpatch complaints addressed,
> 
> 
> They all are about the firmware, not QEMU ifself, do we enforce it for 
> such things as firmwares too?
> 

Well, apparently checkpatch does :) 

More seriously, this code is being added to the QEMU source tree, not
like it is some foreign code imported as a git submodule, so I don't see
why regular QEMU coding style guidelines wouldn't apply ?

> 
> > 
> > Acked-by: Greg Kurz <groug@kaod.org>
> > 
> > and
> > 
> > Tested-by: Greg Kurz <groug@kaod.org>
> 
> 
> Thanks! Now I am thinking whether someone may want to use it for 
> something else, like... dunno... ARM? :)
> 
> 

Well, Zoltan seemed to have some interest in using VOF for
presumably other PowerPC based boards IIUC.

Another future work could be to add enough support to be able
to start grub and boot from a virtio device. :)

Cheers,

--
Greg