[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 5/8] hw/mips/fuloong2e: Remove unused env entry
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH v2 5/8] hw/mips/fuloong2e: Remove unused env entry |
|
Date: |
Tue, 22 Dec 2020 15:42:54 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
On 12/19/20 8:21 AM, Jiaxun Yang wrote:
> modetty and busclock is not handled by kernel and the parameter
> here seems unreasonable.
'busclock' is used by old kernels:
https://elixir.bootlin.com/linux/v3.1/source/arch/mips/loongson/common/env.c#L51
'modetty' is likely here because this code was started using
the YAMON load_kernel() code from malta.c as template.
>
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
> hw/mips/fuloong2e.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/hw/mips/fuloong2e.c b/hw/mips/fuloong2e.c
> index d846ef7b00..c4843dd15e 100644
> --- a/hw/mips/fuloong2e.c
> +++ b/hw/mips/fuloong2e.c
> @@ -159,10 +159,8 @@ static uint64_t load_kernel(CPUMIPSState *env)
> }
>
> /* Setup minimum environment variables */
> - prom_set(prom_buf, index++, "busclock=33000000");
> prom_set(prom_buf, index++, "cpuclock=100000000");
> prom_set(prom_buf, index++, "memsize=%"PRIi64, loaderparams.ram_size /
> MiB);
> - prom_set(prom_buf, index++, "modetty0=38400n8r");
> prom_set(prom_buf, index++, NULL);
>
> rom_add_blob_fixed("prom", prom_buf, prom_size, ENVP_PADDR);
>