Re: Problems with irq mapping in qemu v5.2

[BALATON Zoltan]

On Thu, 24 Dec 2020, Philippe Mathieu-Daudé wrote:
> On Thu, Dec 24, 2020 at 9:11 AM BALATON Zoltan <balaton@eik.bme.hu> wrote:
> > On Wed, 23 Dec 2020, Guenter Roeck wrote:
> > > On Thu, Dec 24, 2020 at 02:34:07AM +0100, BALATON Zoltan wrote:
> > > [ ... ]
> > > > If we need legacy mode then we may be able to emulate that by setting BARs
> > > > to legacy ports ignoring what values are written to them if legacy mode
> > > > config is set (which may be what the real chip does) and we already have
> > > > IRQs hard wired to legacy values so that would give us legacy and
> > > > half-native mode which is enough for both fuloong2e and pegasos2 but I'm not
> > > > sure how can we fix BARs in QEMU because that's also handled by generic PCI
> > > > code which I also don't want to break.
> > >
> > > The code below works for booting Linux while at the same time not affecting
> > > any other emulation. I don't claim it to be a perfect fix, and overloading
> > > the existing property is a bit hackish, but it does work.
> [...]
> > I think we don't need more complete
> > emulation of this chip than this for now but if somebody wants to attempt
> > that I don't mind as long as it does not break pegasos2.
>
> Fine by me as long as pegasos2 doesn't break other OSes :)

Sure, I did try to avoid breaking fuloong2e last time too and tested with 
the kernel I could dig up. Unfortunately that does not seem to be the 
right test for that machine. The fuloong2e model wasn't in very good shape 
back then. Now we have better test cases for it.

> Can we have integration tests of pegasos2 so we can modify the device models
> without introducing regressions?
> If it is not open-source, you could still contribute tests with hash
> of tested binary
> and provide the binary file to test on demand off-list.

We're not there yet when I can submit pegasos2 patches for merging because 
I'll need to make more clean ups to via model and also have a replacement 
for the firmware binary that I plan to do as time permits. For OS there 
may be some older PPC Linux distros that used to work with pegasos2 and 
MorphOS demo is freely downloadable but not redistributable so maybe 
possible to use as test but I'll need some help with the python module to 
integrate it in QEMU tests. I'll keep you cc-d about this anyway as the 
MIPS maintainer.

Regards,
BALATON Zoltan