Re: [PATCH 1/3] qapi, audio: add query-audiodev command

[Daniel P . Berrangé]

On Tue, Mar 02, 2021 at 10:12:43PM +0100, Philippe Mathieu-Daudé wrote:
> On 3/2/21 10:10 PM, Philippe Mathieu-Daudé wrote:
> > On 3/2/21 6:55 PM, Daniel P. Berrangé wrote:
> >> Way back in QEMU 4.0, the -audiodev command line option was introduced
> >> for configuring audio backends. This CLI option does not use QemuOpts
> >> so it is not visible for introspection in 'query-command-line-options',
> >> instead using the QAPI Audiodev type.  Unfortunately there is also no
> >> QMP command that uses the Audiodev type, so it is not introspectable
> >> with 'query-qmp-schema' either.
> >>
> >> This introduces a 'query-audiodev' command that simply reflects back
> >> the list of configured -audiodev command line options. This in turn
> >> makes Audiodev introspectable via 'query-qmp-schema'.
> >>
> >> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> >> ---
> >>  audio/audio.c   | 19 +++++++++++++++++++
> >>  qapi/audio.json | 13 +++++++++++++
> >>  2 files changed, 32 insertions(+)
> > 
> >> +
> >> +##
> >> +# @query-audiodevs:
> >> +#
> >> +# Returns information about audiodev configuration
> >> +#
> >> +# Returns: array of @Audiodev
> 
> Also with chardev we return ChardevBackendInfo. I'm not sure
> if this is because I'm custom to read it, but it seems clearer.
> Can we return a AudiodevBackendInfo type?

Chardevs are not a good guide as they have this wierd split betweeen
manually written Chardev type and QAPI driven ChardeBackendInfo type.

With audio backends, we only have the Audiodev QAPI type. There is
no AudiodevBackendInfo.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|