[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] qapi, audio: add query-audiodev command
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH 1/3] qapi, audio: add query-audiodev command |
Date: |
Wed, 3 Mar 2021 10:08:20 +0000 |
User-agent: |
Mutt/2.0.5 (2021-01-21) |
On Tue, Mar 02, 2021 at 10:10:56PM +0100, Philippe Mathieu-Daudé wrote:
> On 3/2/21 6:55 PM, Daniel P. Berrangé wrote:
> > Way back in QEMU 4.0, the -audiodev command line option was introduced
> > for configuring audio backends. This CLI option does not use QemuOpts
> > so it is not visible for introspection in 'query-command-line-options',
> > instead using the QAPI Audiodev type. Unfortunately there is also no
> > QMP command that uses the Audiodev type, so it is not introspectable
> > with 'query-qmp-schema' either.
> >
> > This introduces a 'query-audiodev' command that simply reflects back
> > the list of configured -audiodev command line options. This in turn
> > makes Audiodev introspectable via 'query-qmp-schema'.
> >
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> > ---
> > audio/audio.c | 19 +++++++++++++++++++
> > qapi/audio.json | 13 +++++++++++++
> > 2 files changed, 32 insertions(+)
>
> > +
> > +##
> > +# @query-audiodevs:
> > +#
> > +# Returns information about audiodev configuration
> > +#
> > +# Returns: array of @Audiodev
> > +#
> > +# Since: 6.0
> > +#
> > +##
> > +{ 'command': 'query-audiodevs',
> > + 'returns': ['Audiodev'] }
> >
>
> Can we use 'query-audiodev-backends' similarly to
> 'query-chardev-backends'?
IMHO adding "-backends" is redundant, because audiodev and chardev
objects are always backends.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [PATCH 2/3] qapi, audio: respect build time conditions in audio schema, (continued)