[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 12/38] hw/block/nvme: fix Close Zone
From: |
Klaus Jensen |
Subject: |
[PULL 12/38] hw/block/nvme: fix Close Zone |
Date: |
Mon, 8 Mar 2021 13:22:47 +0100 |
From: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Implicitly and Explicitly Open zones can be closed by Close Zone
management function. This got broken by a recent commit ("hw/block/nvme:
refactor zone resource management") and now such commands fail with
Invalid Zone State Transition status.
Modify nvm_zrm_close() function to make Close Zone work correctly.
Signed-off-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
---
hw/block/nvme.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 59faebce28f9..5cdf17db512c 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1310,14 +1310,13 @@ static uint16_t nvme_zrm_finish(NvmeNamespace *ns,
NvmeZone *zone)
static uint16_t nvme_zrm_close(NvmeNamespace *ns, NvmeZone *zone)
{
switch (nvme_get_zone_state(zone)) {
- case NVME_ZONE_STATE_CLOSED:
- return NVME_SUCCESS;
-
case NVME_ZONE_STATE_EXPLICITLY_OPEN:
case NVME_ZONE_STATE_IMPLICITLY_OPEN:
nvme_aor_dec_open(ns);
nvme_assign_zone_state(ns, zone, NVME_ZONE_STATE_CLOSED);
/* fall through */
+ case NVME_ZONE_STATE_CLOSED:
+ return NVME_SUCCESS;
default:
return NVME_ZONE_INVAL_TRANSITION;
--
2.30.1
- [PULL 01/38] hw/block/nvme: introduce nvme-subsys device, (continued)
[PULL 04/38] hw/block/nvme: support for multi-controller in subsystem, Klaus Jensen, 2021/03/08
[PULL 02/38] hw/block/nvme: support to map controller to a subsystem, Klaus Jensen, 2021/03/08
[PULL 03/38] hw/block/nvme: add CMIC enum value for Identify Controller, Klaus Jensen, 2021/03/08
[PULL 05/38] hw/block/nvme: add NMIC enum value for Identify Namespace, Klaus Jensen, 2021/03/08
[PULL 07/38] hw/block/nvme: remove unused parameter in check zone write, Klaus Jensen, 2021/03/08
[PULL 12/38] hw/block/nvme: fix Close Zone,
Klaus Jensen <=
[PULL 13/38] hw/block/nvme: add missing mor/mar constraint checks, Klaus Jensen, 2021/03/08
[PULL 06/38] hw/block/nvme: support for shared namespace in subsystem, Klaus Jensen, 2021/03/08
[PULL 09/38] hw/block/nvme: pull write pointer advancement to separate function, Klaus Jensen, 2021/03/08
[PULL 08/38] hw/block/nvme: refactor zone resource management, Klaus Jensen, 2021/03/08
[PULL 10/38] nvme: updated shared header for copy command, Klaus Jensen, 2021/03/08
[PULL 14/38] hw/block/nvme: improve invalid zasl value reporting, Klaus Jensen, 2021/03/08
[PULL 11/38] hw/block/nvme: add simple copy command, Klaus Jensen, 2021/03/08
[PULL 15/38] hw/block/nvme: use locally assigned QEMU IEEE OUI, Klaus Jensen, 2021/03/08
[PULL 16/38] hw/block/nvme: add broadcast nsid support flush command, Klaus Jensen, 2021/03/08
[PULL 17/38] hw/block/nvme: document 'mdts' nvme device parameter, Klaus Jensen, 2021/03/08