[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PULL 01/38] hw/block/nvme: introduce nvme-subsys device
From: |
Peter Maydell |
Subject: |
Re: [PULL 01/38] hw/block/nvme: introduce nvme-subsys device |
Date: |
Mon, 8 Mar 2021 18:53:53 +0000 |
On Mon, 8 Mar 2021 at 18:46, Klaus Jensen <its@irrelevant.dk> wrote:
>
> On Mar 8 19:32, Paolo Bonzini wrote:
> > On 08/03/21 13:22, Klaus Jensen wrote:
> > >
> > > This patch introduced a simple nvme-subsys device model. The subsystem
> > > will be prepared with subsystem NQN with <subsys_id> provided in
> > > nvme-subsys device:
> > >
> > > ex) -device nvme-subsys,id=subsys0: nqn.2019-08.org.qemu:subsys0
> >
> > Hi Klaus, sorry for not spotting this before. In the SCSI subsystem we
> > moved away from using id as guest-visible data. Keeping it as a default is
> > fine I guess, but would it be possible to add an nqn property to nvme-subsys
> > and use it if it is present instead of the id?
> >
> > Thanks,
> >
> > Paolo
> >
>
> Hi Paolo,
>
> Thanks for pointing this out! Absolutely - we have no specific reason to
> use 'id', so we can just change it completely to use 'nqn'.
>
> Peter, you want this in a v2 or did you already start integration of
> this PR?
I haven't yet started working on this PR so if the change is trivial
feel free to roll a v2.
-- PMM
[PULL 04/38] hw/block/nvme: support for multi-controller in subsystem, Klaus Jensen, 2021/03/08
[PULL 02/38] hw/block/nvme: support to map controller to a subsystem, Klaus Jensen, 2021/03/08
[PULL 03/38] hw/block/nvme: add CMIC enum value for Identify Controller, Klaus Jensen, 2021/03/08
[PULL 05/38] hw/block/nvme: add NMIC enum value for Identify Namespace, Klaus Jensen, 2021/03/08
[PULL 07/38] hw/block/nvme: remove unused parameter in check zone write, Klaus Jensen, 2021/03/08
[PULL 12/38] hw/block/nvme: fix Close Zone, Klaus Jensen, 2021/03/08
[PULL 13/38] hw/block/nvme: add missing mor/mar constraint checks, Klaus Jensen, 2021/03/08
[PULL 06/38] hw/block/nvme: support for shared namespace in subsystem, Klaus Jensen, 2021/03/08
[PULL 09/38] hw/block/nvme: pull write pointer advancement to separate function, Klaus Jensen, 2021/03/08