[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 07/14] plugins: expand the typedef kernel-docs for transl
From: |
Aaron Lindsay |
Subject: |
Re: [PATCH v1 07/14] plugins: expand the typedef kernel-docs for translation |
Date: |
Fri, 12 Mar 2021 13:27:04 -0500 |
On Mar 12 17:28, Alex Bennée wrote:
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Aaron Lindsay <aaron@os.amperecomputing.com>
> ---
> include/qemu/qemu-plugin.h | 17 ++++++++++-------
> 1 file changed, 10 insertions(+), 7 deletions(-)
>
> diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
> index 09b235f0b4..9ae3940d89 100644
> --- a/include/qemu/qemu-plugin.h
> +++ b/include/qemu/qemu-plugin.h
> @@ -202,11 +202,9 @@ void qemu_plugin_register_vcpu_idle_cb(qemu_plugin_id_t
> id,
> void qemu_plugin_register_vcpu_resume_cb(qemu_plugin_id_t id,
> qemu_plugin_vcpu_simple_cb_t cb);
>
> -/*
> - * Opaque types that the plugin is given during the translation and
> - * instrumentation phase.
> - */
> +/** struct qemu_plugin_tb - Opaque handle for a translation block */
> struct qemu_plugin_tb;
> +/** struct qemu_plugin_insn - Opaque handle for a translated instruction */
> struct qemu_plugin_insn;
>
> enum qemu_plugin_cb_flags {
> @@ -221,6 +219,14 @@ enum qemu_plugin_mem_rw {
> QEMU_PLUGIN_MEM_RW,
> };
>
> +/**
> + * typedef qemu_plugin_vcpu_tb_trans_cb_t - translation callback
> + * @id: unique plugin id
> + * @tb: opaque handle used for querying and instrumenting a block.
> + */
> +typedef void (*qemu_plugin_vcpu_tb_trans_cb_t)(qemu_plugin_id_t id,
> + struct qemu_plugin_tb *tb);
> +
> /**
> * qemu_plugin_register_vcpu_tb_trans_cb() - register a translate cb
> * @id: plugin ID
> @@ -233,9 +239,6 @@ enum qemu_plugin_mem_rw {
> * callbacks to be triggered when the block or individual instruction
> * executes.
> */
> -typedef void (*qemu_plugin_vcpu_tb_trans_cb_t)(qemu_plugin_id_t id,
> - struct qemu_plugin_tb *tb);
> -
> void qemu_plugin_register_vcpu_tb_trans_cb(qemu_plugin_id_t id,
> qemu_plugin_vcpu_tb_trans_cb_t
> cb);
>
> --
> 2.20.1
>
- [PATCH v1 01/14] plugins: new syscalls plugin, (continued)
- [PATCH v1 01/14] plugins: new syscalls plugin, Alex Bennée, 2021/03/12
- [PATCH v1 03/14] docs/devel: include the plugin API information from the headers, Alex Bennée, 2021/03/12
- [PATCH v1 02/14] plugins: Expose physical addresses instead of device offsets, Alex Bennée, 2021/03/12
- [PATCH v1 05/14] plugins: cleanup kernel-doc for qemu_plugin_install, Alex Bennée, 2021/03/12
- [PATCH v1 08/14] plugins: add qemu_plugin_cb_flags to kernel-doc, Alex Bennée, 2021/03/12
- [PATCH v1 07/14] plugins: expand the typedef kernel-docs for translation, Alex Bennée, 2021/03/12
- Re: [PATCH v1 07/14] plugins: expand the typedef kernel-docs for translation,
Aaron Lindsay <=
- [PATCH v1 10/14] plugins: expand inline exec kernel-doc documentation., Alex Bennée, 2021/03/12
- [PATCH v1 04/14] plugins: expand kernel-doc for qemu_info_t, Alex Bennée, 2021/03/12
- [PATCH v1 06/14] plugins: expand the callback typedef kernel-docs, Alex Bennée, 2021/03/12
- [PATCH v1 12/14] plugins: expand kernel-doc for memory query and instrumentation, Alex Bennée, 2021/03/12