[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v1 12/14] plugins: expand kernel-doc for memory query and in
From: |
Aaron Lindsay |
Subject: |
Re: [PATCH v1 12/14] plugins: expand kernel-doc for memory query and instrumentation |
Date: |
Fri, 12 Mar 2021 13:40:37 -0500 |
On Mar 12 17:28, Alex Bennée wrote:
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Small comment below, but otherwise:
Reviewed-by: Aaron Lindsay <aaron@os.amperecomputing.com>
> ---
> include/qemu/qemu-plugin.h | 35 ++++++++++++++++++++++++++++-------
> 1 file changed, 28 insertions(+), 7 deletions(-)
>
> diff --git a/include/qemu/qemu-plugin.h b/include/qemu/qemu-plugin.h
> index d4adce730a..aed868d42a 100644
> --- a/include/qemu/qemu-plugin.h
> +++ b/include/qemu/qemu-plugin.h
> @@ -392,24 +392,45 @@ uint64_t qemu_plugin_insn_vaddr(const struct
> qemu_plugin_insn *insn);
> */
> void *qemu_plugin_insn_haddr(const struct qemu_plugin_insn *insn);
>
> -/*
> - * Memory Instrumentation
> - *
> - * The anonymous qemu_plugin_meminfo_t and qemu_plugin_hwaddr types
> - * can be used in queries to QEMU to get more information about a
> - * given memory access.
> +/**
> + * typedef qemu_plugin_meminfo_t - opaque memory transaction handle
Would it still be useful to include the types of things you can do
with a qemu_plugin_meminfo_t here?
- [PATCH v1 07/14] plugins: expand the typedef kernel-docs for translation, (continued)
- [PATCH v1 07/14] plugins: expand the typedef kernel-docs for translation, Alex Bennée, 2021/03/12
- [PATCH v1 10/14] plugins: expand inline exec kernel-doc documentation., Alex Bennée, 2021/03/12
- [PATCH v1 04/14] plugins: expand kernel-doc for qemu_info_t, Alex Bennée, 2021/03/12
- [PATCH v1 06/14] plugins: expand the callback typedef kernel-docs, Alex Bennée, 2021/03/12
- [PATCH v1 12/14] plugins: expand kernel-doc for memory query and instrumentation, Alex Bennée, 2021/03/12
- Re: [PATCH v1 12/14] plugins: expand kernel-doc for memory query and instrumentation,
Aaron Lindsay <=
- [PATCH v1 09/14] plugins: add qemu_plugin_id_t to kernel-doc, Alex Bennée, 2021/03/12
- [PATCH v1 13/14] plugins: getting qemu_plugin_get_hwaddr only expose one function prototype, Alex Bennée, 2021/03/12
- [PATCH v1 11/14] plugins: expand kernel-doc for instruction query and instrumentation, Alex Bennée, 2021/03/12
- [PATCH v1 14/14] plugins: Fixes typo in qemu-plugin.h, Alex Bennée, 2021/03/12