[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 09/13] hw/net: ne2000: Remove the logic of padding short frame
From: |
Bin Meng |
Subject: |
[PATCH v2 09/13] hw/net: ne2000: Remove the logic of padding short frames in the receive path |
Date: |
Mon, 15 Mar 2021 15:57:14 +0800 |
Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
---
hw/net/ne2000.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c
index 6c17ee1ae2..b0a120ece6 100644
--- a/hw/net/ne2000.c
+++ b/hw/net/ne2000.c
@@ -167,15 +167,12 @@ static int ne2000_buffer_full(NE2000State *s)
return 0;
}
-#define MIN_BUF_SIZE 60
-
ssize_t ne2000_receive(NetClientState *nc, const uint8_t *buf, size_t size_)
{
NE2000State *s = qemu_get_nic_opaque(nc);
size_t size = size_;
uint8_t *p;
unsigned int total_len, next, avail, len, index, mcast_idx;
- uint8_t buf1[60];
static const uint8_t broadcast_macaddr[6] =
{ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff };
@@ -213,15 +210,6 @@ ssize_t ne2000_receive(NetClientState *nc, const uint8_t
*buf, size_t size_)
}
}
-
- /* if too small buffer, then expand it */
- if (size < MIN_BUF_SIZE) {
- memcpy(buf1, buf, size);
- memset(buf1 + size, 0, MIN_BUF_SIZE - size);
- buf = buf1;
- size = MIN_BUF_SIZE;
- }
-
index = s->curpag << 8;
if (index >= NE2000_PMEM_END) {
index = s->start;
--
2.25.1
- Re: [PATCH v2 02/13] net: Add a 'do_not_pad" to NetClientState, (continued)
[PATCH v2 04/13] net: tap: Pad short frames to minimum size before send, Bin Meng, 2021/03/15
[PATCH v2 03/13] net: slirp: Pad short frames to minimum size before send, Bin Meng, 2021/03/15
[PATCH v2 05/13] hw/net: virtio-net: Initialize nc->do_not_pad to true, Bin Meng, 2021/03/15
[PATCH v2 07/13] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15
[PATCH v2 06/13] hw/net: e1000: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15
[PATCH v2 08/13] hw/net: i82596: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15
[PATCH v2 09/13] hw/net: ne2000: Remove the logic of padding short frames in the receive path,
Bin Meng <=
[PATCH v2 10/13] hw/net: pcnet: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15
[PATCH v2 11/13] hw/net: rtl8139: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15
[PATCH v2 12/13] hw/net: sungem: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15
[PATCH v2 13/13] hw/net: sunhme: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15