[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/13] net: Add a 'do_not_pad" to NetClientState
From: |
Bin Meng |
Subject: |
Re: [PATCH v2 02/13] net: Add a 'do_not_pad" to NetClientState |
Date: |
Mon, 15 Mar 2021 18:17:28 +0800 |
Hi Philippe,
On Mon, Mar 15, 2021 at 5:22 PM Philippe Mathieu-Daudé
<philmd@redhat.com> wrote:
>
> On 3/15/21 10:18 AM, Philippe Mathieu-Daudé wrote:
> > On 3/15/21 10:17 AM, Philippe Mathieu-Daudé wrote:
> >> On 3/15/21 8:57 AM, Bin Meng wrote:
> >>> This adds a flag in NetClientState, so that a net client can tell
> >>> its peer that the packets do not need to be padded to the minimum
> >>> size of an Ethernet frame (60 bytes) before sending to it.
> >>>
> >>> Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
> >>> ---
> >>>
> >>> include/net/net.h | 1 +
> >>> 1 file changed, 1 insertion(+)
> >>>
> >>> diff --git a/include/net/net.h b/include/net/net.h
> >>> index 919facaad2..6fab1f83f5 100644
> >>> --- a/include/net/net.h
> >>> +++ b/include/net/net.h
> >>> @@ -100,6 +100,7 @@ struct NetClientState {
> >>> int vring_enable;
> >>> int vnet_hdr_len;
> >>> bool is_netdev;
> >>> + bool do_not_pad;
>
> Maybe 'do_not_pad_to_min_eth_frame_len' to avoid
> wondering what padding is it.
I felt the same when I added this :) But I wonder if that name is too long ..
Regards,
Bin
[PATCH v2 04/13] net: tap: Pad short frames to minimum size before send, Bin Meng, 2021/03/15
[PATCH v2 03/13] net: slirp: Pad short frames to minimum size before send, Bin Meng, 2021/03/15
[PATCH v2 05/13] hw/net: virtio-net: Initialize nc->do_not_pad to true, Bin Meng, 2021/03/15
[PATCH v2 07/13] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15
[PATCH v2 06/13] hw/net: e1000: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15
[PATCH v2 08/13] hw/net: i82596: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15
[PATCH v2 09/13] hw/net: ne2000: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15
[PATCH v2 10/13] hw/net: pcnet: Remove the logic of padding short frames in the receive path, Bin Meng, 2021/03/15