RE: [PATCH v3 25/41] target/hexagon: Remove hexagon_cpu_tlb_fill

[Taylor Simpson]

> -----Original Message-----
> From: Richard Henderson <richard.henderson@linaro.org>
> Sent: Friday, October 1, 2021 12:12 PM
> To: qemu-devel@nongnu.org
> Cc: laurent@vivier.eu; alex.bennee@linaro.org; Taylor Simpson
> <tsimpson@quicinc.com>
> Subject: [PATCH v3 25/41] target/hexagon: Remove hexagon_cpu_tlb_fill
> 
> The fallback code in raise_sigsegv is sufficient for hexagon.
> Remove the code from cpu_loop that raises SIGSEGV.
> 
> Cc: Taylor Simpson <tsimpson@quicinc.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  linux-user/hexagon/cpu_loop.c | 24 +-----------------------
>  target/hexagon/cpu.c          | 23 -----------------------
>  2 files changed, 1 insertion(+), 46 deletions(-)

You should update the commit comment because raise_sigsegv was changed to 
cpu_loop_exit_segv in v3 of the patch series.

Otherwise,
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>